Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/fieldMutations.test.ts

Summary

Maintainability
F
3 days
Test Coverage

File fieldMutations.test.ts has 519 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as faker from 'faker';
import { graphqlRequest } from '../db/connection';
import {
  boardFactory,
  fieldFactory,
Severity: Major
Found in api/src/__tests__/fieldMutations.test.ts - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      test('Update order field', async () => {
    const orders = [
      {
        _id: _field._id,
        order: 1
    Severity: Major
    Found in api/src/__tests__/fieldMutations.test.ts and 1 other location - About 6 hrs to fix
    api/src/__tests__/fieldMutations.test.ts on lines 566..595

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 157.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      test('Update order fieldGroup', async () => {
    const orders = [
      {
        _id: _fieldGroup._id,
        order: 1
    Severity: Major
    Found in api/src/__tests__/fieldMutations.test.ts and 1 other location - About 6 hrs to fix
    api/src/__tests__/fieldMutations.test.ts on lines 255..284

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 157.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

      test('Remove field', async () => {
    const mutation = `
      mutation fieldsRemove($_id: String!) {
        fieldsRemove(_id: $_id) {
          _id
    Severity: Major
    Found in api/src/__tests__/fieldMutations.test.ts and 8 other locations - About 2 hrs to fix
    api/src/__tests__/channelMutations.test.ts on lines 131..146
    api/src/__tests__/checklistMutations.test.ts on lines 244..263
    api/src/__tests__/emailTemplateMutations.test.ts on lines 91..108
    api/src/__tests__/fieldMutations.test.ts on lines 524..538
    api/src/__tests__/growthHackMutations.test.ts on lines 277..294
    api/src/__tests__/responseTemplateMutations.test.ts on lines 136..153
    api/src/__tests__/segmentMutations.test.ts on lines 174..189
    api/src/__tests__/ticketMutations.test.ts on lines 243..260

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

      test('Remove group field', async () => {
    const mutation = `
      mutation fieldsGroupsRemove($_id: String!) {
        fieldsGroupsRemove(_id: $_id)
      }
    Severity: Major
    Found in api/src/__tests__/fieldMutations.test.ts and 8 other locations - About 2 hrs to fix
    api/src/__tests__/channelMutations.test.ts on lines 131..146
    api/src/__tests__/checklistMutations.test.ts on lines 244..263
    api/src/__tests__/emailTemplateMutations.test.ts on lines 91..108
    api/src/__tests__/fieldMutations.test.ts on lines 236..253
    api/src/__tests__/growthHackMutations.test.ts on lines 277..294
    api/src/__tests__/responseTemplateMutations.test.ts on lines 136..153
    api/src/__tests__/segmentMutations.test.ts on lines 174..189
    api/src/__tests__/ticketMutations.test.ts on lines 243..260

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 82.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 23 locations. Consider refactoring.
    Open

      afterEach(async () => {
    // Clearing test data
    await Users.deleteMany({});
    await Fields.deleteMany({});
    await FieldsGroups.deleteMany({});
    Severity: Major
    Found in api/src/__tests__/fieldMutations.test.ts and 22 other locations - About 1 hr to fix
    api/src/__tests__/boardQueries.test.ts on lines 92..97
    api/src/__tests__/brandMutations.test.ts on lines 27..32
    api/src/__tests__/channelMutations.test.ts on lines 26..31
    api/src/__tests__/checklistDb.test.ts on lines 51..56
    api/src/__tests__/checklistMutations.test.ts on lines 34..39
    api/src/__tests__/companyMutations.test.ts on lines 51..56
    api/src/__tests__/conversationDb.test.ts on lines 37..42
    api/src/__tests__/fieldDb.test.ts on lines 24..29
    api/src/__tests__/formMutations.test.ts on lines 38..43
    api/src/__tests__/importHistoryDb.test.ts on lines 7..12
    api/src/__tests__/knowledgeBaseQueries.test.ts on lines 17..22
    api/src/__tests__/notificationQueries.test.ts on lines 31..36
    api/src/__tests__/permissionMutations.test.ts on lines 46..51
    api/src/__tests__/permissionUtil.test.ts on lines 64..69
    api/src/__tests__/pipelineLabelMutations.test.ts on lines 55..60
    api/src/__tests__/productDb.test.ts on lines 31..36
    api/src/__tests__/productMutations.test.ts on lines 76..81
    api/src/__tests__/productQueries.test.ts on lines 15..20
    api/src/__tests__/tagMutations.test.ts on lines 47..52
    api/src/__tests__/userMutations.test.ts on lines 95..100
    api/src/__tests__/userQueries.test.ts on lines 16..21
    api/src/__tests__/widgetMutations.test.ts on lines 869..874

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          const fieldGroupWithCode = await graphqlRequest(
        mutation,
        'fieldsGroupsAdd',
        {
          ...fieldGroupArgs,
    Severity: Minor
    Found in api/src/__tests__/fieldMutations.test.ts and 1 other location - About 35 mins to fix
    api/src/__tests__/fieldMutations.test.ts on lines 460..464

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            await graphqlRequest(mutation, 'fieldsGroupsAdd', {
          ...fieldGroupArgs,
          code,
          boardsPipelines: [{ boardId: board._id, pipelineIds: [pipeline._id] }]
        });
    Severity: Minor
    Found in api/src/__tests__/fieldMutations.test.ts and 1 other location - About 35 mins to fix
    api/src/__tests__/fieldMutations.test.ts on lines 447..455

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status