Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/formDb.test.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Similar blocks of code found in 5 locations. Consider refactoring.
Open

test('Get form', async () => {
  const form = await formFactory();

  try {
    await Forms.getForm('fakeId');
Severity: Major
Found in api/src/__tests__/formDb.test.ts and 4 other locations - About 3 hrs to fix
api/src/__tests__/channelDb.test.ts on lines 38..50
api/src/__tests__/knowledgeBaseDb.test.ts on lines 40..52
api/src/__tests__/knowledgeBaseDb.test.ts on lines 160..172
api/src/__tests__/knowledgeBaseDb.test.ts on lines 343..355

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 105.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

  afterEach(async () => {
    await Forms.deleteMany({});
    await Fields.deleteMany({});
    await Customers.deleteMany({});
    await FormSubmissions.deleteMany({});
Severity: Major
Found in api/src/__tests__/formDb.test.ts and 7 other locations - About 1 hr to fix
api/src/__tests__/httpEndpoints.test.ts on lines 18..23
api/src/__tests__/integrationDb.test.ts on lines 204..209
api/src/__tests__/integrationDb.test.ts on lines 240..245
api/src/__tests__/integrationDb.test.ts on lines 301..306
api/src/__tests__/integrationDb.test.ts on lines 983..988
api/src/__tests__/skillMutations.test.ts on lines 13..18
api/src/__tests__/structureDb.test.ts on lines 25..30

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 68.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

  afterEach(async () => {
    await Users.deleteMany({});
    await Fields.deleteMany({});
    await Forms.deleteMany({});
  });
Severity: Major
Found in api/src/__tests__/formDb.test.ts and 4 other locations - About 55 mins to fix
api/src/__tests__/channelDb.test.ts on lines 32..36
api/src/__tests__/knowledgeBaseDb.test.ts on lines 34..38
api/src/__tests__/skillDb.test.ts on lines 42..46
integrations/src/__tests__/twitter.test.ts on lines 78..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status