Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/internalNoteDb.test.ts

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('removeCompanyInternalNotes', async () => {
    const company = await companyFactory({});

    await internalNoteFactory({
      contentType: ACTIVITY_CONTENT_TYPES.COMPANY,
Severity: Major
Found in api/src/__tests__/internalNoteDb.test.ts and 1 other location - About 5 hrs to fix
api/src/__tests__/internalNoteDb.test.ts on lines 138..159

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 154.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('removeCustomerInternalNotes', async () => {
    const customer = await customerFactory({});

    await internalNoteFactory({
      contentType: ACTIVITY_CONTENT_TYPES.CUSTOMER,
Severity: Major
Found in api/src/__tests__/internalNoteDb.test.ts and 1 other location - About 5 hrs to fix
api/src/__tests__/internalNoteDb.test.ts on lines 161..182

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 154.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('changeCompany', async () => {
    const company = await companyFactory({});
    const newCompany = await companyFactory({});

    await internalNoteFactory({
Severity: Major
Found in api/src/__tests__/internalNoteDb.test.ts and 1 other location - About 4 hrs to fix
api/src/__tests__/internalNoteDb.test.ts on lines 100..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  test('changeCustomer', async () => {
    const customer = await customerFactory({});
    const newCustomer = await customerFactory({});

    await internalNoteFactory({
Severity: Major
Found in api/src/__tests__/internalNoteDb.test.ts and 1 other location - About 4 hrs to fix
api/src/__tests__/internalNoteDb.test.ts on lines 119..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 18 locations. Consider refactoring.
Open

  test('Get internal note', async () => {
    try {
      await InternalNotes.getInternalNote('fakeId');
    } catch (e) {
      expect(e.message).toBe('Internal note not found');
Severity: Major
Found in api/src/__tests__/internalNoteDb.test.ts and 17 other locations - About 2 hrs to fix
api/src/__tests__/boardDb.test.ts on lines 479..489
api/src/__tests__/checklistDb.test.ts on lines 58..68
api/src/__tests__/checklistDb.test.ts on lines 70..80
api/src/__tests__/companyDb.test.ts on lines 66..76
api/src/__tests__/conversationDb.test.ts on lines 44..56
api/src/__tests__/conversationDb.test.ts on lines 58..68
api/src/__tests__/customerDb.test.ts on lines 47..57
api/src/__tests__/dashboardDb.test.ts on lines 22..32
api/src/__tests__/dealDb.test.ts on lines 59..69
api/src/__tests__/emailTemplateDb.test.ts on lines 19..29
api/src/__tests__/engageMessageDb.test.ts on lines 66..76
api/src/__tests__/responseTemplateDb.test.ts on lines 19..31
api/src/__tests__/segmentDb.test.ts on lines 69..79
api/src/__tests__/tagDb.test.ts on lines 29..39
api/src/__tests__/ticketDb.test.ts on lines 44..54
api/src/__tests__/userDb.test.ts on lines 26..36
api/src/__tests__/webhookDb.test.ts on lines 22..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

const checkValues = (internalNoteObj, doc) => {
  expect(internalNoteObj.contentType).toBe(doc.contentType);
  expect(internalNoteObj.contentTypeId).toBe(doc.contentTypeId);
  expect(internalNoteObj.content).toBe(doc.content);
};
Severity: Major
Found in api/src/__tests__/internalNoteDb.test.ts and 1 other location - About 2 hrs to fix
api/src/__tests__/checklistDb.test.ts on lines 31..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 85.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status