Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/__tests__/knowledgeBaseDb.test.ts

Summary

Maintainability
F
3 days
Test Coverage

File knowledgeBaseDb.test.ts has 358 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as toBeType from 'jest-tobetype';
import {
  brandFactory,
  knowledgeBaseArticleFactory,
  knowledgeBaseCategoryFactory,
Severity: Minor
Found in api/src/__tests__/knowledgeBaseDb.test.ts - About 4 hrs to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        test('Get knowledge base article', async () => {
      const article = await knowledgeBaseArticleFactory();

      try {
        await KnowledgeBaseArticles.getArticle('fakeId');
    Severity: Major
    Found in api/src/__tests__/knowledgeBaseDb.test.ts and 4 other locations - About 3 hrs to fix
    api/src/__tests__/channelDb.test.ts on lines 38..50
    api/src/__tests__/formDb.test.ts on lines 44..56
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 40..52
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 160..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        test('Get knowledge base topic', async () => {
      const topic = await knowledgeBaseTopicFactory();

      try {
        await KnowledgeBaseTopics.getTopic('fakeId');
    Severity: Major
    Found in api/src/__tests__/knowledgeBaseDb.test.ts and 4 other locations - About 3 hrs to fix
    api/src/__tests__/channelDb.test.ts on lines 38..50
    api/src/__tests__/formDb.test.ts on lines 44..56
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 160..172
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 343..355

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        test('Get knowledge base category', async () => {
      const category = await knowledgeBaseCategoryFactory();

      try {
        await KnowledgeBaseCategories.getCategory('fakeId');
    Severity: Major
    Found in api/src/__tests__/knowledgeBaseDb.test.ts and 4 other locations - About 3 hrs to fix
    api/src/__tests__/channelDb.test.ts on lines 38..50
    api/src/__tests__/formDb.test.ts on lines 44..56
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 40..52
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 343..355

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        test(`check if Error('userId must be supplied') in create`, async () => {
      expect.assertions(1);

      try {
        await KnowledgeBaseCategories.createDoc({ title: 'New Category' });
    Severity: Major
    Found in api/src/__tests__/knowledgeBaseDb.test.ts and 1 other location - About 2 hrs to fix
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 357..365

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        test(`check if Error('userId must be supplied') when creating`, async () => {
      expect.assertions(1);

      try {
        await KnowledgeBaseArticles.createDoc({ title: 'New article' });
    Severity: Major
    Found in api/src/__tests__/knowledgeBaseDb.test.ts and 1 other location - About 2 hrs to fix
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 174..182

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        test(`check if Error('userId must be supplied') in update`, async () => {
      expect.assertions(1);

      try {
        await KnowledgeBaseCategories.updateDoc('fakeId', {});
    Severity: Major
    Found in api/src/__tests__/knowledgeBaseDb.test.ts and 2 other locations - About 2 hrs to fix
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 65..74
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 383..391

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        test(`check if Error('userId must be supplied') when updating`, async () => {
      expect.assertions(1);

      try {
        await KnowledgeBaseArticles.updateDoc('fakeId', {});
    Severity: Major
    Found in api/src/__tests__/knowledgeBaseDb.test.ts and 2 other locations - About 2 hrs to fix
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 65..74
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 205..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        test(`check if Error('userId must be supplied')
     is being called as intended on update method`, async () => {
      expect.assertions(1);

      try {
    Severity: Major
    Found in api/src/__tests__/knowledgeBaseDb.test.ts and 2 other locations - About 2 hrs to fix
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 205..213
    api/src/__tests__/knowledgeBaseDb.test.ts on lines 383..391

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 76.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        afterEach(async () => {
      await KnowledgeBaseTopics.deleteMany({});
      await Brands.deleteMany({});
      await KnowledgeBaseCategories.deleteMany({});
    });
    Severity: Major
    Found in api/src/__tests__/knowledgeBaseDb.test.ts and 4 other locations - About 55 mins to fix
    api/src/__tests__/channelDb.test.ts on lines 32..36
    api/src/__tests__/formDb.test.ts on lines 136..140
    api/src/__tests__/skillDb.test.ts on lines 42..46
    integrations/src/__tests__/twitter.test.ts on lines 78..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status