Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/data/modules/fileExporter/exporter.ts

Summary

Maintainability
F
5 days
Test Coverage

Function buildFile has a Cognitive Complexity of 70 (exceeds 5 allowed). Consider refactoring.
Open

export const buildFile = async (
  query: any,
  user: IUserDocument
): Promise<{ name: string; response: string }> => {
  const { configs } = query;
Severity: Minor
Found in api/src/data/modules/fileExporter/exporter.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prepareData has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

const prepareData = async (query: any, user: IUserDocument): Promise<any[]> => {
  const { type, unlimited = false, segment } = query;

  let data: any[] = [];
Severity: Minor
Found in api/src/data/modules/fileExporter/exporter.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function prepareData has 145 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const prepareData = async (query: any, user: IUserDocument): Promise<any[]> => {
  const { type, unlimited = false, segment } = query;

  let data: any[] = [];
Severity: Major
Found in api/src/data/modules/fileExporter/exporter.ts - About 5 hrs to fix

    File exporter.ts has 397 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as moment from 'moment';
import {
  Brands,
  Channels,
  ConversationMessages,
    Severity: Minor
    Found in api/src/data/modules/fileExporter/exporter.ts - About 5 hrs to fix

      Function buildFile has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const buildFile = async (
  query: any,
  user: IUserDocument
): Promise<{ name: string; response: string }> => {
  const { configs } = query;
      Severity: Major
      Found in api/src/data/modules/fileExporter/exporter.ts - About 3 hrs to fix

        Function fillDealProductValue has 55 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const fillDealProductValue = async (
  column,
  item,
  sheet,
  columnNames,
        Severity: Major
        Found in api/src/data/modules/fileExporter/exporter.ts - About 2 hrs to fix

          Function buildLeadFile has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          const buildLeadFile = async (
  datas: any,
  formId: string,
  sheet: any,
  columnNames: string[],
          Severity: Minor
          Found in api/src/data/modules/fileExporter/exporter.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function buildLeadFile has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          const buildLeadFile = async (
  datas: any,
  formId: string,
  sheet: any,
  columnNames: string[],
          Severity: Minor
          Found in api/src/data/modules/fileExporter/exporter.ts - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                    } else if (column.name.startsWith('productsData')) {
          const indexes = await fillDealProductValue(
            column,
            item,
            sheet,
            Severity: Major
            Found in api/src/data/modules/fileExporter/exporter.ts - About 45 mins to fix

              Function fillDealProductValue has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              const fillDealProductValue = async (
  column,
  item,
  sheet,
  columnNames,
              Severity: Minor
              Found in api/src/data/modules/fileExporter/exporter.ts - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                        if (item.customFieldsData && item.customFieldsData.length > 0) {
            for (const customFeild of item.customFieldsData) {
              const fieldId = column.name.split('.')[1];

              const field = await Fields.findOne({
              Severity: Major
              Found in api/src/data/modules/fileExporter/exporter.ts - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    case 'visitor':
      const visitorParams: ICustomerListArgs = query;
      const visitorQp = new CustomerBuildQuery(visitorParams, {});
      await visitorQp.buildAllQueries();
                Severity: Major
                Found in api/src/data/modules/fileExporter/exporter.ts and 1 other location - About 1 hr to fix
                api/src/data/modules/fileExporter/exporter.ts on lines 65..73

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 72.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    case 'lead':
      const leadParams: ICustomerListArgs = query;
      const leadQp = new CustomerBuildQuery(leadParams, {});
      await leadQp.buildAllQueries();
                Severity: Major
                Found in api/src/data/modules/fileExporter/exporter.ts and 1 other location - About 1 hr to fix
                api/src/data/modules/fileExporter/exporter.ts on lines 75..83

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 72.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    case MODULE_NAMES.TASK:
      if (!(await can('exportTasks', user))) {
        throw new Error('Permission denied');
      }
                Severity: Major
                Found in api/src/data/modules/fileExporter/exporter.ts and 2 other locations - About 40 mins to fix
                api/src/data/modules/fileExporter/exporter.ts on lines 172..179
                api/src/data/modules/fileExporter/exporter.ts on lines 188..195

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    case MODULE_NAMES.DEAL:
      if (!(await can('exportDeals', user))) {
        throw new Error('Permission denied');
      }
                Severity: Major
                Found in api/src/data/modules/fileExporter/exporter.ts and 2 other locations - About 40 mins to fix
                api/src/data/modules/fileExporter/exporter.ts on lines 180..187
                api/src/data/modules/fileExporter/exporter.ts on lines 188..195

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    case MODULE_NAMES.TICKET:
      if (!(await can('exportTickets', user))) {
        throw new Error('Permission denied');
      }
                Severity: Major
                Found in api/src/data/modules/fileExporter/exporter.ts and 2 other locations - About 40 mins to fix
                api/src/data/modules/fileExporter/exporter.ts on lines 172..179
                api/src/data/modules/fileExporter/exporter.ts on lines 180..187

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 49.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    case MODULE_NAMES.CHANNEL:
      if (!(await can('exportChannels', user))) {
        throw new Error('Permission denied');
      }
                Severity: Minor
                Found in api/src/data/modules/fileExporter/exporter.ts and 2 other locations - About 40 mins to fix
                api/src/data/modules/fileExporter/exporter.ts on lines 204..211
                api/src/data/modules/fileExporter/exporter.ts on lines 212..219

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    case MODULE_NAMES.PERMISSION:
      if (!(await can('exportPermissions', user))) {
        throw new Error('Permission denied');
      }
                Severity: Minor
                Found in api/src/data/modules/fileExporter/exporter.ts and 2 other locations - About 40 mins to fix
                api/src/data/modules/fileExporter/exporter.ts on lines 212..219
                api/src/data/modules/fileExporter/exporter.ts on lines 220..227

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    case MODULE_NAMES.BRAND:
      if (!(await can('exportBrands', user))) {
        throw new Error('Permission denied');
      }
                Severity: Minor
                Found in api/src/data/modules/fileExporter/exporter.ts and 2 other locations - About 40 mins to fix
                api/src/data/modules/fileExporter/exporter.ts on lines 204..211
                api/src/data/modules/fileExporter/exporter.ts on lines 220..227

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status