Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/data/resolvers/mutations/boardUtils.ts

Summary

Maintainability
F
4 days
Test Coverage

File boardUtils.ts has 582 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import resolvers from '..';
import {
  Boards,
  Fields,
  Notifications,
Severity: Major
Found in api/src/data/resolvers/mutations/boardUtils.ts - About 1 day to fix

    Function itemsEdit has 129 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const itemsEdit = async (
  _id: string,
  type: string,
  oldItem: any,
  doc: any,
    Severity: Major
    Found in api/src/data/resolvers/mutations/boardUtils.ts - About 5 hrs to fix

      Function itemsChange has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const itemsChange = async (
  doc: IItemDragCommonFields,
  type: string,
  user: IUserDocument,
  modelUpdate: any
      Severity: Major
      Found in api/src/data/resolvers/mutations/boardUtils.ts - About 2 hrs to fix

        Function itemsAdd has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const itemsAdd = async (
  doc: (IDeal | IItemCommonFields | ITicket | IGrowthHack) & {
    proccessId: string;
    aboveItemId: string;
  },
        Severity: Major
        Found in api/src/data/resolvers/mutations/boardUtils.ts - About 2 hrs to fix

          Function itemsCopy has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export const itemsCopy = async (
  _id: string,
  proccessId: string,
  type: string,
  user: IUserDocument,
          Severity: Minor
          Found in api/src/data/resolvers/mutations/boardUtils.ts - About 1 hr to fix

            Function itemsArchive has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            export const itemsArchive = async (
  stageId: string,
  type: string,
  proccessId: string,
  user: IUserDocument
            Severity: Minor
            Found in api/src/data/resolvers/mutations/boardUtils.ts - About 1 hr to fix

              Function itemMover has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const itemMover = async (
  userId: string,
  item: IDealDocument | ITaskDocument | ITicketDocument | IGrowthHackDocument,
  contentType: string,
  destinationStageId: string
              Severity: Minor
              Found in api/src/data/resolvers/mutations/boardUtils.ts - About 1 hr to fix

                Function itemsEdit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                export const itemsEdit = async (
  _id: string,
  type: string,
  oldItem: any,
  doc: any,
                Severity: Minor
                Found in api/src/data/resolvers/mutations/boardUtils.ts - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  graphqlPubsub.publish('pipelinesChanged', {
    pipelinesChanged: {
      _id: stage.pipelineId,
      proccessId,
      action: 'itemAdd',
                Severity: Major
                Found in api/src/data/resolvers/mutations/boardUtils.ts and 1 other location - About 2 hrs to fix
                api/src/data/resolvers/mutations/boardUtils.ts on lines 603..614

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 81.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  graphqlPubsub.publish('pipelinesChanged', {
    pipelinesChanged: {
      _id: stage.pipelineId,
      proccessId,
      action: 'itemAdd',
                Severity: Major
                Found in api/src/data/resolvers/mutations/boardUtils.ts and 1 other location - About 2 hrs to fix
                api/src/data/resolvers/mutations/boardUtils.ts on lines 228..239

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 81.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    graphqlPubsub.publish('pipelinesChanged', {
      pipelinesChanged: {
        _id: stage.pipelineId,
        proccessId,
        action: 'itemsRemove',
                Severity: Major
                Found in api/src/data/resolvers/mutations/boardUtils.ts and 2 other locations - About 1 hr to fix
                api/src/data/resolvers/mutations/boardUtils.ts on lines 186..196
                api/src/data/resolvers/mutations/boardUtils.ts on lines 339..349

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    graphqlPubsub.publish('pipelinesChanged', {
      pipelinesChanged: {
        _id: stage.pipelineId,
        proccessId,
        action: 'itemRemove',
                Severity: Major
                Found in api/src/data/resolvers/mutations/boardUtils.ts and 2 other locations - About 1 hr to fix
                api/src/data/resolvers/mutations/boardUtils.ts on lines 339..349
                api/src/data/resolvers/mutations/boardUtils.ts on lines 655..665

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    graphqlPubsub.publish('pipelinesChanged', {
      pipelinesChanged: {
        _id: oldStage.pipelineId,
        proccessId,
        action: 'itemRemove',
                Severity: Major
                Found in api/src/data/resolvers/mutations/boardUtils.ts and 2 other locations - About 1 hr to fix
                api/src/data/resolvers/mutations/boardUtils.ts on lines 186..196
                api/src/data/resolvers/mutations/boardUtils.ts on lines 655..665

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  switch (type) {
    case 'deal':
      resolverType = 'Deal';
      break;
                Severity: Minor
                Found in api/src/data/resolvers/mutations/boardUtils.ts and 1 other location - About 50 mins to fix
                ui/src/modules/activityLogs/components/items/checklist/ChecklistItem.tsx on lines 36..49

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status