Sign upLogin

erxes/erxes

View on GitHub
Star
api/src/db/models/Structure.ts

Summary

Maintainability
F
6 days
Test Coverage

Function loadDepartmentClass has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const loadDepartmentClass = () => {
  class Department {
    /*
     * Get a department
     */
Severity: Minor
Found in api/src/db/models/Structure.ts - About 1 hr to fix

    Function loadBranchClass has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const loadBranchClass = () => {
  class Branch {
    /*
     * Get a branch
     */
    Severity: Minor
    Found in api/src/db/models/Structure.ts - About 1 hr to fix

      Function loadStructureClass has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export const loadStructureClass = () => {
  class Structure {
    /*
     * Get a structure
     */
      Severity: Minor
      Found in api/src/db/models/Structure.ts - About 1 hr to fix

        Function loadUnitClass has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const loadUnitClass = () => {
  class Unit {
    /*
     * Get an unit
     */
        Severity: Minor
        Found in api/src/db/models/Structure.ts - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          export const loadBranchClass = () => {
  class Branch {
    /*
     * Get a branch
     */
          Severity: Major
          Found in api/src/db/models/Structure.ts and 2 other locations - About 1 day to fix
          api/src/db/models/Structure.ts on lines 25..84
          api/src/db/models/Structure.ts on lines 183..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 285.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          export const loadStructureClass = () => {
  class Structure {
    /*
     * Get a structure
     */
          Severity: Major
          Found in api/src/db/models/Structure.ts and 2 other locations - About 1 day to fix
          api/src/db/models/Structure.ts on lines 183..238
          api/src/db/models/Structure.ts on lines 252..311

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 285.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          export const loadUnitClass = () => {
  class Unit {
    /*
     * Get an unit
     */
          Severity: Major
          Found in api/src/db/models/Structure.ts and 2 other locations - About 1 day to fix
          api/src/db/models/Structure.ts on lines 25..84
          api/src/db/models/Structure.ts on lines 252..311

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 285.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          export interface IDepartmentModel extends Model<IDepartmentDocument> {
  getDepartment(doc: any): IDepartmentDocument;
  createDepartment(doc: any, user: IUserDocument): IDepartmentDocument;
  updateDepartment(
    _id: string,
          Severity: Major
          Found in api/src/db/models/Structure.ts and 3 other locations - About 3 hrs to fix
          api/src/db/models/Structure.ts on lines 14..23
          api/src/db/models/Structure.ts on lines 176..181
          api/src/db/models/Structure.ts on lines 245..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          export interface IStructureModel extends Model<IStructureDocument> {
  getStructure(doc: any): IStructureDocument;
  createStructure(doc: any, user: IUserDocument): IStructureDocument;
  updateStructure(
    _id: string,
          Severity: Major
          Found in api/src/db/models/Structure.ts and 3 other locations - About 3 hrs to fix
          api/src/db/models/Structure.ts on lines 94..103
          api/src/db/models/Structure.ts on lines 176..181
          api/src/db/models/Structure.ts on lines 245..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          export interface IUnitModel extends Model<IUnitDocument> {
  getUnit(doc: any): IUnitDocument;
  createUnit(doc: any, user: IUserDocument): IUnitDocument;
  updateUnit(_id: string, doc: any, user: IUserDocument): IUnitDocument;
  removeUnit(_id: string): IUnitDocument;
          Severity: Major
          Found in api/src/db/models/Structure.ts and 3 other locations - About 3 hrs to fix
          api/src/db/models/Structure.ts on lines 14..23
          api/src/db/models/Structure.ts on lines 94..103
          api/src/db/models/Structure.ts on lines 245..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          export interface IBranchModel extends Model<IBranchDocument> {
  getBranch(doc: any): IBranchDocument;
  createBranch(doc: any, user: IUserDocument): IBranchDocument;
  updateBranch(_id: string, doc: any, user: IUserDocument): IBranchDocument;
  removeBranch(_id: string): IBranchDocument;
          Severity: Major
          Found in api/src/db/models/Structure.ts and 3 other locations - About 3 hrs to fix
          api/src/db/models/Structure.ts on lines 14..23
          api/src/db/models/Structure.ts on lines 94..103
          api/src/db/models/Structure.ts on lines 176..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 98.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status