Sign upLogin

espressopp/espressopp

View on GitHub
Star
examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressDensityFEC.py

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    for i in range(len(density_array)):
        if(i>=len(density_array_total)):
            density_array_total.append(density_array[i])
        else:
            density_array_total[i] += density_array[i]
Severity: Major
Found in examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressDensityFEC.py and 7 other locations - About 3 hrs to fix
examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressPressureFEC.py on lines 241..245
examples/adress/hadress_tetraliquid/hadress_tetraliquid_plain/hadress.py on lines 243..247
examples/adress/hadress_tetraliquid/hadress_tetraliquid_plain/hadress.py on lines 252..256
examples/adress/piadress_water/AdaptivePIwater.py on lines 394..398
examples/adress/piadress_water/AdaptivePIwater.py on lines 402..406
examples/adress/piadress_water/AdaptivePIwater.py on lines 410..414
examples/stillinger_weber_Si/stillinger_weber_silicon.py on lines 221..225

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

for i in range( len(density_array_total) ):
    tempFile.write(fmt % ( (i+0.5)*dr, density_array_total[i] ))
Severity: Major
Found in examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressDensityFEC.py and 8 other locations - About 2 hrs to fix
examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressPressureFEC.py on lines 259..260
examples/adress/hadress_tetraliquid/hadress_tetraliquid_plain/hadress.py on lines 270..271
examples/adress/hadress_tetraliquid/hadress_tetraliquid_plain/hadress.py on lines 285..286
examples/adress/piadress_water/AdaptivePIwater.py on lines 446..447
examples/adress/piadress_water/AdaptivePIwater.py on lines 454..455
examples/adress/piadress_water/AdaptivePIwater.py on lines 462..463
examples/adress/piadress_water/AdaptivePIwater.py on lines 471..472
examples/adress/piadress_water/AdaptivePIwater.py on lines 480..481

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

vl = espressopp.VerletListAdress(system, cutoff=rc, adrcut=rc,
                                dEx=ex_size, dHy=hy_size,
                                adrCenter=[Lx/2, Ly/2, Lz/2])
Severity: Major
Found in examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressDensityFEC.py and 5 other locations - About 1 hr to fix
examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressPressureFEC.py on lines 150..152
examples/adress/hadress_tetraliquid/hadress_tetraliquid_KTI/hadressKTI.py on lines 144..146
examples/adress/hadress_tetraliquid/hadress_tetraliquid_plain/hadress.py on lines 146..148
examples/adress/hadress_water/water.py on lines 101..103
examples/adress/multiple_time_stepping_fadress/water_mts_fadress.py on lines 166..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    sys.stdout.write(fmt % (step, T, Ek + Ep + Eb + Ecorr, Ep, Eb, Ek, Ecorr))
Severity: Major
Found in examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressDensityFEC.py and 1 other location - About 1 hr to fix
examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressPressureFEC.py on lines 237..237

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

sys.stdout.write(fmt % (0, T, Ek + Ep + Eb + Ecorr, Ep, Eb, Ek, Ecorr))
Severity: Major
Found in examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressDensityFEC.py and 1 other location - About 1 hr to fix
examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressPressureFEC.py on lines 216..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

fec = espressopp.integrator.FreeEnergyCompensation(system, center=[Lx/2, Ly/2, Lz/2])
Severity: Major
Found in examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressDensityFEC.py and 1 other location - About 1 hr to fix
examples/adress/hadress_tetraliquid/hadress_tetraliquid_FEC/hadressPressureFEC.py on lines 185..185

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 39.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status