Sign upLogin

espressopp/espressopp

View on GitHub
Star
testsuite/AdResS/ForceAdResS/test_AdResS.py

Summary

Maintainability
F
2 wks
Test Coverage

Function test_ATATCG_template has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def test_ATATCG_template(self):
        # add some particles
        particle_list = [
            (1, 1, 0, espressopp.Real3D(5.5, 5.0, 5.0), 1.0, 0),
            (2, 1, 0, espressopp.Real3D(6.5, 5.0, 5.0), 1.0, 0),
Severity: Minor
Found in testsuite/AdResS/ForceAdResS/test_AdResS.py - About 1 hr to fix

    Function test_fixed_sphere has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def test_fixed_sphere(self):
        # add some particles
        particle_list = [
            (1, 1, espressopp.Real3D(5.0, 5.5, 5.0), 1.0, 0),
            (2, 1, espressopp.Real3D(5.0, 6.5, 5.0), 1.0, 0),
    Severity: Minor
    Found in testsuite/AdResS/ForceAdResS/test_AdResS.py - About 1 hr to fix

      Function test_moving_sphere has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def test_moving_sphere(self):
        # add some particles
        particle_list = [
            (1, 1, espressopp.Real3D(5.0, 5.5, 5.0), 1.0, 0),
            (2, 1, espressopp.Real3D(5.0, 6.5, 5.0), 1.0, 0),
      Severity: Minor
      Found in testsuite/AdResS/ForceAdResS/test_AdResS.py - About 1 hr to fix

        Function test_slab has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def test_slab(self):
        # add some particles
        particle_list = [
            (1,  1, espressopp.Real3D(5.5, 5.0, 5.0), 1.0, 0),
            (2,  1, espressopp.Real3D(6.5, 5.0, 5.0), 1.0, 0),
        Severity: Minor
        Found in testsuite/AdResS/ForceAdResS/test_AdResS.py - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_ATATCG_template(self):
        # add some particles
        particle_list = [
            (1, 1, 0, espressopp.Real3D(5.5, 5.0, 5.0), 1.0, 0),
            (2, 1, 0, espressopp.Real3D(6.5, 5.0, 5.0), 1.0, 0),
          Severity: Major
          Found in testsuite/AdResS/ForceAdResS/test_AdResS.py and 1 other location - About 1 wk to fix
          testsuite/AdResS/HAdResS/test_HAdResS.py on lines 184..254

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 979.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  particle_list = [
            (1, 1, espressopp.Real3D(5.0, 5.5, 5.0), 1.0, 0),
            (2, 1, espressopp.Real3D(5.0, 6.5, 5.0), 1.0, 0),
            (3, 1, espressopp.Real3D(5.0, 7.5, 5.0), 1.0, 0),
            (4, 1, espressopp.Real3D(5.0, 8.5, 5.0), 1.0, 0),
          Severity: Major
          Found in testsuite/AdResS/ForceAdResS/test_AdResS.py and 2 other locations - About 1 day to fix
          testsuite/AdResS/ForceAdResS/test_AdResS.py on lines 45..55
          testsuite/AdResS/ForceAdResS/test_AdResS.py on lines 186..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 156.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  particle_list = [
            (1, 1, espressopp.Real3D(5.0, 5.5, 5.0), 1.0, 0),
            (2, 1, espressopp.Real3D(5.0, 6.5, 5.0), 1.0, 0),
            (3, 1, espressopp.Real3D(5.0, 7.5, 5.0), 1.0, 0),
            (4, 1, espressopp.Real3D(5.0, 8.5, 5.0), 1.0, 0),
          Severity: Major
          Found in testsuite/AdResS/ForceAdResS/test_AdResS.py and 2 other locations - About 1 day to fix
          testsuite/AdResS/ForceAdResS/test_AdResS.py on lines 45..55
          testsuite/AdResS/ForceAdResS/test_AdResS.py on lines 116..126

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 156.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  particle_list = [
            (1,  1, espressopp.Real3D(5.5, 5.0, 5.0), 1.0, 0),
            (2,  1, espressopp.Real3D(6.5, 5.0, 5.0), 1.0, 0),
            (3,  1, espressopp.Real3D(7.5, 5.0, 5.0), 1.0, 0),
            (4,  1, espressopp.Real3D(8.5, 5.0, 5.0), 1.0, 0),
          Severity: Major
          Found in testsuite/AdResS/ForceAdResS/test_AdResS.py and 2 other locations - About 1 day to fix
          testsuite/AdResS/ForceAdResS/test_AdResS.py on lines 116..126
          testsuite/AdResS/ForceAdResS/test_AdResS.py on lines 186..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 156.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 7 locations. Consider refactoring.
          Open

              def setUp(self):
        # set up system
        system = espressopp.System()
        box = (10, 10, 10)
        system.bc = espressopp.bc.OrthorhombicBC(system.rng, box)
          Severity: Major
          Found in testsuite/AdResS/ForceAdResS/test_AdResS.py and 6 other locations - About 1 day to fix
          testsuite/AdResS/AdressDensity/test_AdressDensity.py on lines 31..41
          testsuite/AdResS/FreeEnergyCompensation/test_FreeEnergyCompensation.py on lines 32..42
          testsuite/AdResS/HAdResS/test_HAdResS.py on lines 31..41
          testsuite/AdResS/TDforce/test_TDforce.py on lines 31..41
          testsuite/rattle/testRattle.py on lines 36..46
          testsuite/thermo_integration/testThermoIntegration.py on lines 31..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 138.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status