Sign upLogin

espressopp/espressopp

View on GitHub
Star
testsuite/AdResS/MTSAdResS/test_MTSAdResS.py

Summary

Maintainability
F
3 wks
Test Coverage

Function test_ATAT_CG_templates_HAdResS has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def test_ATAT_CG_templates_HAdResS(self):
        # add atomistic interactions
        interNBat = espressopp.interaction.VerletListHadressATLenJonesReacFieldGen(self.vl, self.ftpl)
        potLJ  = espressopp.interaction.LennardJones(epsilon=0.650299305951, sigma=0.316549165245, shift='auto', cutoff=1.4)
        potQQ  = espressopp.interaction.ReactionFieldGeneralized(prefactor=138.935485, kappa=0.0, epsilon1=1.0, epsilon2=80.0, cutoff= 1.4, shift="auto")
Severity: Minor
Found in testsuite/AdResS/MTSAdResS/test_MTSAdResS.py - About 1 hr to fix

    Function test_ATAT_CG_templates_FAdResS has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def test_ATAT_CG_templates_FAdResS(self):
        # add atomistic interactions
        interNBat = espressopp.interaction.VerletListAdressATLenJonesReacFieldGen(self.vl, self.ftpl)
        potLJ  = espressopp.interaction.LennardJones(epsilon=0.650299305951, sigma=0.316549165245, shift='auto', cutoff=1.4)
        potQQ  = espressopp.interaction.ReactionFieldGeneralized(prefactor=138.935485, kappa=0.0, epsilon1=1.0, epsilon2=80.0, cutoff= 1.4, shift="auto")
    Severity: Minor
    Found in testsuite/AdResS/MTSAdResS/test_MTSAdResS.py - About 1 hr to fix

      Function test_AT_CG_templates_HAdResS has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def test_AT_CG_templates_HAdResS(self):
        # add atomistic interaction
        interNBat = espressopp.interaction.VerletListHadressATLennardJones(self.vl, self.ftpl)
        potLJ  = espressopp.interaction.LennardJones(epsilon=0.650299305951, sigma=0.316549165245, shift='auto', cutoff=1.4)
        interNBat.setPotential(type1=0, type2=0, potential=potLJ)
      Severity: Minor
      Found in testsuite/AdResS/MTSAdResS/test_MTSAdResS.py - About 1 hr to fix

        Function test_AT_CG_templates_FAdResS has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def test_AT_CG_templates_FAdResS(self):
        # add atomistic interaction
        interNBat = espressopp.interaction.VerletListAdressATLennardJones(self.vl, self.ftpl)
        potLJ  = espressopp.interaction.LennardJones(epsilon=0.650299305951, sigma=0.316549165245, shift='auto', cutoff=1.4)
        interNBat.setPotential(type1=0, type2=0, potential=potLJ)
        Severity: Minor
        Found in testsuite/AdResS/MTSAdResS/test_MTSAdResS.py - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_ATAT_CG_templates_HAdResS(self):
        # add atomistic interactions
        interNBat = espressopp.interaction.VerletListHadressATLenJonesReacFieldGen(self.vl, self.ftpl)
        potLJ  = espressopp.interaction.LennardJones(epsilon=0.650299305951, sigma=0.316549165245, shift='auto', cutoff=1.4)
        potQQ  = espressopp.interaction.ReactionFieldGeneralized(prefactor=138.935485, kappa=0.0, epsilon1=1.0, epsilon2=80.0, cutoff= 1.4, shift="auto")
          Severity: Major
          Found in testsuite/AdResS/MTSAdResS/test_MTSAdResS.py and 1 other location - About 6 days to fix
          testsuite/AdResS/MTSAdResS/test_MTSAdResS.py on lines 166..212

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 693.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_ATAT_CG_templates_FAdResS(self):
        # add atomistic interactions
        interNBat = espressopp.interaction.VerletListAdressATLenJonesReacFieldGen(self.vl, self.ftpl)
        potLJ  = espressopp.interaction.LennardJones(epsilon=0.650299305951, sigma=0.316549165245, shift='auto', cutoff=1.4)
        potQQ  = espressopp.interaction.ReactionFieldGeneralized(prefactor=138.935485, kappa=0.0, epsilon1=1.0, epsilon2=80.0, cutoff= 1.4, shift="auto")
          Severity: Major
          Found in testsuite/AdResS/MTSAdResS/test_MTSAdResS.py and 1 other location - About 6 days to fix
          testsuite/AdResS/MTSAdResS/test_MTSAdResS.py on lines 72..118

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 693.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_AT_CG_templates_HAdResS(self):
        # add atomistic interaction
        interNBat = espressopp.interaction.VerletListHadressATLennardJones(self.vl, self.ftpl)
        potLJ  = espressopp.interaction.LennardJones(epsilon=0.650299305951, sigma=0.316549165245, shift='auto', cutoff=1.4)
        interNBat.setPotential(type1=0, type2=0, potential=potLJ)
          Severity: Major
          Found in testsuite/AdResS/MTSAdResS/test_MTSAdResS.py and 1 other location - About 6 days to fix
          testsuite/AdResS/MTSAdResS/test_MTSAdResS.py on lines 214..258

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 646.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              def test_AT_CG_templates_FAdResS(self):
        # add atomistic interaction
        interNBat = espressopp.interaction.VerletListAdressATLennardJones(self.vl, self.ftpl)
        potLJ  = espressopp.interaction.LennardJones(epsilon=0.650299305951, sigma=0.316549165245, shift='auto', cutoff=1.4)
        interNBat.setPotential(type1=0, type2=0, potential=potLJ)
          Severity: Major
          Found in testsuite/AdResS/MTSAdResS/test_MTSAdResS.py and 1 other location - About 6 days to fix
          testsuite/AdResS/MTSAdResS/test_MTSAdResS.py on lines 120..164

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 646.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status