Sign upLogin

estimancy/projestimate

View on GitHub
Star
app/controllers/wbs_activities_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

Method save_effort_breakdown has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

  def save_effort_breakdown
    authorize! :execute_estimation_plan, @project

    @pbs_project_element = current_component
    @tmp_results = Hash.new
Severity: Minor
Found in app/controllers/wbs_activities_controller.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method save_effort_breakdown has 103 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def save_effort_breakdown
    authorize! :execute_estimation_plan, @project

    @pbs_project_element = current_component
    @tmp_results = Hash.new
Severity: Major
Found in app/controllers/wbs_activities_controller.rb - About 4 hrs to fix

    File wbs_activities_controller.rb has 309 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'will_paginate/array'

class WbsActivitiesController < ApplicationController
  #include DataValidationHelper #Module for master data changes validation
  include ModuleProjectsHelper
    Severity: Minor
    Found in app/controllers/wbs_activities_controller.rb - About 3 hrs to fix

      Method duplicate_wbs_activity has 47 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def duplicate_wbs_activity
    #Update ancestry depth caching
    WbsActivityElement.rebuild_depth_cache!

    begin
      Severity: Minor
      Found in app/controllers/wbs_activities_controller.rb - About 1 hr to fix

        Method validate_change_with_children has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def validate_change_with_children
    begin
      wbs_activity = WbsActivity.find(params[:id])
      wbs_activity_root_element = WbsActivityElement.where('wbs_activity_id = ? and is_root = ?', wbs_activity.id, true).first
        Severity: Minor
        Found in app/controllers/wbs_activities_controller.rb - About 1 hr to fix

          Method duplicate_wbs_activity has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def duplicate_wbs_activity
    #Update ancestry depth caching
    WbsActivityElement.rebuild_depth_cache!

    begin
          Severity: Minor
          Found in app/controllers/wbs_activities_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method validate_change_with_children has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def validate_change_with_children
    begin
      wbs_activity = WbsActivity.find(params[:id])
      wbs_activity_root_element = WbsActivityElement.where('wbs_activity_id = ? and is_root = ?', wbs_activity.id, true).first
          Severity: Minor
          Found in app/controllers/wbs_activities_controller.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method wbs_record_statuses_collection has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def wbs_record_statuses_collection
    #No authorize required since this method is protected and won't be call from route
    if @wbs_activity.new_record?
      if is_master_instance?
        @wbs_record_status_collection = RecordStatus.where('name = ?', 'Proposed').defined
          Severity: Minor
          Found in app/controllers/wbs_activities_controller.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method edit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def edit
    #no authorize required since everyone can show this object

    set_page_title 'WBS activities'
    @wbs_activity = WbsActivity.find(params[:id])
          Severity: Minor
          Found in app/controllers/wbs_activities_controller.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method enable_update_in_local? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def enable_update_in_local?
    #No authorize required since this method is protected and won't be call from route
    if is_master_instance?
      true
    else
          Severity: Minor
          Found in app/controllers/wbs_activities_controller.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            def enable_update_in_local?
    #No authorize required since this method is protected and won't be call from route
    if is_master_instance?
      true
    else
          Severity: Minor
          Found in app/controllers/wbs_activities_controller.rb and 2 other locations - About 30 mins to fix
          app/controllers/projects_controller.rb on lines 55..69
          app/controllers/wbs_activity_ratios_controller.rb on lines 174..188

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 33.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status