Sign upLogin

estimancy/projestimate

View on GitHub
Star
app/models/home.rb

Summary

Maintainability
F
1 wk
Test Coverage

Method update_records has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
Open

  def self.update_records(external, local, fields)
    loc_defined_rs_id = RecordStatus.find_by_name('Defined').id
    loc_custom_rs_id = RecordStatus.find_by_name('Custom').id
    loc_local_rs_id = RecordStatus.find_by_name('Local').id
    ext_defined_rs_id = ExternalMasterDatabase::ExternalRecordStatus.find_by_name('Defined').id
Severity: Minor
Found in app/models/home.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load_master_data! has 320 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.load_master_data!
    db=Home::connect_external_database
    #begin
    record_status = ExternalMasterDatabase::ExternalRecordStatus.all
    record_status.each do |i|
Severity: Major
Found in app/models/home.rb - About 1 day to fix

    File home.rb has 543 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'open-uri'
require 'mysql2'

class Home < ActiveRecord::Base
  attr_accessible
    Severity: Major
    Found in app/models/home.rb - About 1 day to fix

      Method load_master_data! has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.load_master_data!
    db=Home::connect_external_database
    #begin
    record_status = ExternalMasterDatabase::ExternalRecordStatus.all
    record_status.each do |i|
      Severity: Minor
      Found in app/models/home.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method update_records has 117 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.update_records(external, local, fields)
    loc_defined_rs_id = RecordStatus.find_by_name('Defined').id
    loc_custom_rs_id = RecordStatus.find_by_name('Custom').id
    loc_local_rs_id = RecordStatus.find_by_name('Local').id
    ext_defined_rs_id = ExternalMasterDatabase::ExternalRecordStatus.find_by_name('Defined').id
      Severity: Major
      Found in app/models/home.rb - About 4 hrs to fix

        Method update_master_data! has 66 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.update_master_data!
    db=Home::connect_external_database
    puts 'Updating from Master Data...'

    #begin
        Severity: Major
        Found in app/models/home.rb - About 2 hrs to fix

          Method update_master_data! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.update_master_data!
    db=Home::connect_external_database
    puts 'Updating from Master Data...'

    #begin
          Severity: Minor
          Found in app/models/home.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                        unless ext_ancestry.nil?
                ext_ancestry_list = ext.ancestry.split('/')
                ext_ancestry_list.each do |ancestor|
                  ext_ancestor_uuid = ExternalMasterDatabase::ExternalWbsActivityElement.find_by_id(ancestor).uuid
                  ancestors << WbsActivityElement.find_by_uuid(ext_ancestor_uuid).id
          Severity: Major
          Found in app/models/home.rb - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                ext_pemodules.each do |ext_module|
      ext_attr_modules.each do |ext_attr_module|
        if ext_module.id == ext_attr_module.pemodule_id and ext_module.record_status_id == ext_defined_rs_id
          loc_module = Pemodule.find_by_uuid(ext_module.uuid)
          ext_attr = ExternalMasterDatabase::ExternalPeAttribute.find_by_id(ext_attr_module.pe_attribute_id)
            Severity: Major
            Found in app/models/home.rb and 1 other location - About 1 hr to fix
            app/models/home.rb on lines 413..422

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                ext_pemodules.each do |ext_module|
      ext_attr_modules.each do |ext_attr_module|
        if ext_module.id == ext_attr_module.pemodule_id and ext_module.record_status_id == ext_defined_rs_id
          loc_module = Pemodule.find_by_uuid(ext_module.uuid)
          ext_attr = ExternalMasterDatabase::ExternalPeAttribute.find_by_id(ext_attr_module.pe_attribute_id)
            Severity: Major
            Found in app/models/home.rb and 1 other location - About 1 hr to fix
            app/models/home.rb on lines 80..89

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                ext_records_permission_project.each do |record|
      ext_permission_uuid=Array.new
      ext_project_security_level_uuid=Array.new
      ext_permission= db.query("SELECT uuid FROM permissions where id=#{record[0]}")
      ext_permission.each do |row|
            Severity: Major
            Found in app/models/home.rb and 1 other location - About 1 hr to fix
            app/models/home.rb on lines 722..736

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  ext_records_permission.each do |record|
        ext_permission_uuid=Array.new
        ext_group_uuid=Array.new
        ext_permission= db.query("SELECT uuid FROM permissions where id=#{record[0]}")
        ext_permission.each do |row|
            Severity: Major
            Found in app/models/home.rb and 1 other location - About 1 hr to fix
            app/models/home.rb on lines 771..785

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        ActiveRecord::Base.transaction do
              ancestors = []
              ext_ancestry = ext.ancestry
              unless ext_ancestry.nil?
                ext_ancestry_list = ext.ancestry.split('/')
            Severity: Major
            Found in app/models/home.rb and 1 other location - About 1 hr to fix
            app/models/home.rb on lines 454..467

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      ActiveRecord::Base.transaction do
            ancestors = []
            ext_ancestry = ext_elt.ancestry
            unless ext_ancestry.nil?
              ext_ancestry_list = ext_elt.ancestry.split('/')
            Severity: Major
            Found in app/models/home.rb and 1 other location - About 1 hr to fix
            app/models/home.rb on lines 312..325

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  SizeUnit.all.each do |su|
        s2.organization.organization_technologies.each do |ot|
          TechnologySizeType.create(organization_id: s2.organization_id,
                                    organization_technology_id: ot.id,
                                    size_unit_id: su.id,
            Severity: Minor
            Found in app/models/home.rb and 2 other locations - About 20 mins to fix
            app/models/home.rb on lines 623..629
            app/models/home.rb on lines 645..651

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 28.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  SizeUnit.all.each do |su|
        s3.organization.organization_technologies.each do |ot|
          TechnologySizeType.create(organization_id: s3.organization_id,
                                    organization_technology_id: ot.id,
                                    size_unit_id: su.id,
            Severity: Minor
            Found in app/models/home.rb and 2 other locations - About 20 mins to fix
            app/models/home.rb on lines 623..629
            app/models/home.rb on lines 634..640

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 28.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  SizeUnit.all.each do |su|
        s1.organization.organization_technologies.each do |ot|
          TechnologySizeType.create(organization_id: s1.organization_id,
                                    organization_technology_id: ot.id,
                                    size_unit_id: su.id,
            Severity: Minor
            Found in app/models/home.rb and 2 other locations - About 20 mins to fix
            app/models/home.rb on lines 634..640
            app/models/home.rb on lines 645..651

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 28.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status