Sign upLogin

estimancy/projestimate

View on GitHub
Star
app/workers/estimations_worker.rb

Summary

Maintainability
C
1 day
Test Coverage

Method perform has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def perform(pbs_project_elt_id, estimation_value_id)
    #No authorize required since this method is private and won't be call from any route

    pbs_project_elt = PbsProjectElement.find(pbs_project_elt_id)
    estimation_value = EstimationValue.find(estimation_value_id)
Severity: Minor
Found in app/workers/estimations_worker.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compute_component_estimation_value has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def compute_component_estimation_value(component, pe_attribute_id, level_estimation_value, wbs_project_elt_root=nil)
    #No authorize required since this method is private and won't be call from any route
    component_children_results_array = Array.new
    new_effort_person_hour = Hash.new
    pe_attribute = PeAttribute.find(pe_attribute_id)
Severity: Minor
Found in app/workers/estimations_worker.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compute_component_estimation_value has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def compute_component_estimation_value(component, pe_attribute_id, level_estimation_value, wbs_project_elt_root=nil)
    #No authorize required since this method is private and won't be call from any route
    component_children_results_array = Array.new
    new_effort_person_hour = Hash.new
    pe_attribute = PeAttribute.find(pe_attribute_id)
Severity: Minor
Found in app/workers/estimations_worker.rb - About 1 hr to fix

    Method perform has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def perform(pbs_project_elt_id, estimation_value_id)
    #No authorize required since this method is private and won't be call from any route

    pbs_project_elt = PbsProjectElement.find(pbs_project_elt_id)
    estimation_value = EstimationValue.find(estimation_value_id)
    Severity: Minor
    Found in app/workers/estimations_worker.rb - About 1 hr to fix

      Method compute_estimation_values_with_activities has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def compute_estimation_values_with_activities(in_out, module_project_id, wbs_project_elt_root_id, component_id)
    module_project = ModuleProject.find(module_project_id)

    # The in_out attribute tells if it is an input or output
    case in_out
      Severity: Minor
      Found in app/workers/estimations_worker.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if wbs_project_elt_root.nil?
        node_children_results_array << level_estimation_value[component.id]
      else
        wbs_est_val = level_estimation_value[component.id][wbs_project_elt_root.id]
        node_children_results_array << wbs_est_val.nil? ? nil : wbs_est_val[:value]
      Severity: Minor
      Found in app/workers/estimations_worker.rb and 1 other location - About 20 mins to fix
      app/workers/estimations_worker.rb on lines 85..91

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if wbs_project_elt_root.nil?
          node_children_results_array << level_estimation_value[child.id]
        else
          # get value with activities
          wbs_est_val = level_estimation_value[child.id][wbs_project_elt_root.id]
      Severity: Minor
      Found in app/workers/estimations_worker.rb and 1 other location - About 20 mins to fix
      app/workers/estimations_worker.rb on lines 94..99

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status