Sign upLogin

estimancy/projestimate

View on GitHub
Star

Showing 1,675 of 1,675 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if @profile.is_custom?
      #logical deletion  delete don't have to suppress records anymore on Defined record
      @profile.update_attributes(:record_status_id => @retired_status.id, :owner_id => current_user.id)
      flash[:notice] = I18n.t (:notice_profile_successful_deleted)
    elsif @profile.is_defined?
Severity: Minor
Found in app/controllers/profiles_controller.rb and 1 other location - About 40 mins to fix
app/controllers/languages_controller.rb on lines 110..119

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def destroy
    authorize! :manage_master_data, :all

    @pemodule = Pemodule.find(params[:id])
    if @pemodule.is_defined? || @pemodule.is_custom?
Severity: Minor
Found in app/controllers/pemodules_controller.rb and 1 other location - About 40 mins to fix
app/controllers/permissions_controller.rb on lines 112..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        _super.addSegment("Straight", {
                            x1:current[0], y1:current[1], x2:current[2], y2:current[3]
                        });
Severity: Minor
Found in app/assets/javascripts/jquery.jsPlumb-1.4.1-all.js and 1 other location - About 40 mins to fix
app/assets/javascripts/jquery.jsPlumb-1.4.1-all.js on lines 7900..7902

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        $widget.attr({
            'data-col': new_wgd.col,
            'data-row': new_wgd.row,
            'data-sizex': new_wgd.size_x,
            'data-sizey': new_wgd.size_y
Severity: Minor
Found in app/assets/javascripts/jquery.gridster.js and 1 other location - About 40 mins to fix
app/assets/javascripts/jquery.gridster.js on lines 1707..1712

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  def destroy
    authorize! :manage_master_data, :all

    @permission = Permission.find(params[:id])
    if @permission.is_defined? || @permission.is_custom?
Severity: Minor
Found in app/controllers/permissions_controller.rb and 1 other location - About 40 mins to fix
app/controllers/pemodules_controller.rb on lines 186..197

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if @language.is_custom?
      #logical deletion  delete don't have to suppress records anymore on Defined record
      @language.update_attributes(:record_status_id => @retired_status.id, :owner_id => current_user.id)
      flash[:notice] = I18n.t (:notice_language_successful_deleted)
    elsif @language.is_defined?
Severity: Minor
Found in app/controllers/languages_controller.rb and 1 other location - About 40 mins to fix
app/controllers/profiles_controller.rb on lines 93..102

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  initialize: function(nodeFrom, nodeTo, data, Edge, Label) {
Severity: Minor
Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

    Function buildSelect has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            buildSelect: function(table, column, arry, updating, onlyAvail) {
    Severity: Minor
    Found in app/assets/javascripts/tablesorter.min.js - About 35 mins to fix

      Function getBoundaries has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        function getBoundaries(graph, config, level, orn, prop) {
      Severity: Minor
      Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

        Function parseFilter has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                parseFilter: function(c, filter, column, parsed, forceParse){
        Severity: Minor
        Found in app/assets/javascripts/tablesorter.min.js - About 35 mins to fix

          Function squarify has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

           squarify: function(tail, initElem, w, coord, prop) {
          Severity: Minor
          Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

            Function initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              initialize: function(opt, klass, Node, Edge, Label) {
            Severity: Minor
            Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

              Function number has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      'number': function(elem, prop, delta, getter, setter) {
              Severity: Minor
              Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

                Function fit has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  function fit(ext1, ext2, subtreeOffset, siblingOffset, i) {
                Severity: Minor
                Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

                  Function render has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      'render': function(from, to, dim, swap, canvas){
                  Severity: Minor
                  Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

                    Function render has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        'render': function(type, pos, width, height, canvas){
                    Severity: Minor
                    Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

                      Function render has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          'render': function(type, pos, width, height, canvas){
                      Severity: Minor
                      Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

                        Function color has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                'color': function(elem, prop, delta, getter, setter) {
                        Severity: Minor
                        Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

                          Function design has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                            function design(graph, node, prop, config, orn) {
                          Severity: Minor
                          Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix

                            Function array-number has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    'array-number': function(elem, prop, delta, getter, setter) {
                            Severity: Minor
                            Found in app/assets/javascripts/jit-2.0.1.js - About 35 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language