estimancy/projestimate

View on GitHub
lib/data_validation_helper.rb

Summary

Maintainability
C
1 day
Test Coverage

Method restore_change has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

  def restore_change
    authorize! :manage_master_data, :all

    #get the record controller name
    controller = params[:controller]    #controller.controller_name
Severity: Minor
Found in lib/data_validation_helper.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method restore_change has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def restore_change
    authorize! :manage_master_data, :all

    #get the record controller name
    controller = params[:controller]    #controller.controller_name
Severity: Major
Found in lib/data_validation_helper.rb - About 2 hrs to fix

    Method validate_change has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      def validate_change
        authorize! :manage_master_data, :all
    
        #get the record controller name
        controller = params[:controller]    #controller.controller_name
    Severity: Minor
    Found in lib/data_validation_helper.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_change has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def validate_change
        authorize! :manage_master_data, :all
    
        #get the record controller name
        controller = params[:controller]    #controller.controller_name
    Severity: Major
    Found in lib/data_validation_helper.rb - About 2 hrs to fix

      There are no issues that match your filters.

      Category
      Status