Sign upLogin

etehtsea/oxblood

View on GitHub
Star

Showing 130 of 130 total issues

Module has too many lines. [112/100]
Open

    module Server
      # Asynchronously rewrite the append-only file.
      # @see https://redis.io/commands/bgrewriteaof
      #
      # @return [String] always 'OK'
Severity: Minor
Found in lib/oxblood/commands/server.rb by rubocop

This cop checks if the length a module exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [28/10]
Open

      def parse(io)
        line = io.gets(TERMINATOR)

        case line[0]
        when SIMPLE_STRING
Severity: Minor
Found in lib/oxblood/protocol.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [23/10]
Open

      def client_kill(opts_or_addr = {})
        if opts_or_addr.is_a?(String)
          run(:CLIENT, :KILL, opts_or_addr)
        else
          args = [:CLIENT, :KILL]
Severity: Minor
Found in lib/oxblood/commands/server.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for parse is too high. [24.49/15]
Open

      def parse(io)
        line = io.gets(TERMINATOR)

        case line[0]
        when SIMPLE_STRING
Severity: Minor
Found in lib/oxblood/protocol.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [15/10]
Open

      def add_georadius_opts!(args, opts)
        args << :WITHCOORD if opts[:withcoord]
        args << :WITHDIST if opts[:withdist]
        args << :WITHHASH if opts[:withhash]
Severity: Minor
Found in lib/oxblood/commands/geo.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [15/10]
Open

      def build_command(command = nil, *args)
        return EMPTY_ARRAY_RESPONSE if command.nil?

        result = append!(command, COMMAND_HEADER.dup)
        size = 1
Severity: Minor
Found in lib/oxblood/protocol.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for parse is too high. [11/6]
Open

      def parse(io)
        line = io.gets(TERMINATOR)

        case line[0]
        when SIMPLE_STRING
Severity: Minor
Found in lib/oxblood/protocol.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Assignment Branch Condition size for client_kill is too high. [18.81/15]
Open

      def client_kill(opts_or_addr = {})
        if opts_or_addr.is_a?(String)
          run(:CLIENT, :KILL, opts_or_addr)
        else
          args = [:CLIENT, :KILL]
Severity: Minor
Found in lib/oxblood/commands/server.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Cyclomatic complexity for add_georadius_opts! is too high. [8/6]
Open

      def add_georadius_opts!(args, opts)
        args << :WITHCOORD if opts[:withcoord]
        args << :WITHDIST if opts[:withdist]
        args << :WITHHASH if opts[:withhash]
Severity: Minor
Found in lib/oxblood/commands/geo.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Cyclomatic complexity for client_kill is too high. [8/6]
Open

      def client_kill(opts_or_addr = {})
        if opts_or_addr.is_a?(String)
          run(:CLIENT, :KILL, opts_or_addr)
        else
          args = [:CLIENT, :KILL]
Severity: Minor
Found in lib/oxblood/commands/server.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Assignment Branch Condition size for add_georadius_opts! is too high. [16.16/15]
Open

      def add_georadius_opts!(args, opts)
        args << :WITHCOORD if opts[:withcoord]
        args << :WITHDIST if opts[:withdist]
        args << :WITHHASH if opts[:withhash]
Severity: Minor
Found in lib/oxblood/commands/geo.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Perceived complexity for add_georadius_opts! is too high. [8/7]
Open

      def add_georadius_opts!(args, opts)
        args << :WITHCOORD if opts[:withcoord]
        args << :WITHDIST if opts[:withdist]
        args << :WITHHASH if opts[:withhash]
Severity: Minor
Found in lib/oxblood/commands/geo.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Perceived complexity for client_kill is too high. [8/7]
Open

      def client_kill(opts_or_addr = {})
        if opts_or_addr.is_a?(String)
          run(:CLIENT, :KILL, opts_or_addr)
        else
          args = [:CLIENT, :KILL]
Severity: Minor
Found in lib/oxblood/commands/server.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method client_kill has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def client_kill(opts_or_addr = {})
        if opts_or_addr.is_a?(String)
          run(:CLIENT, :KILL, opts_or_addr)
        else
          args = [:CLIENT, :KILL]
Severity: Minor
Found in lib/oxblood/commands/server.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def parse(io)
        line = io.gets(TERMINATOR)

        case line[0]
        when SIMPLE_STRING
Severity: Minor
Found in lib/oxblood/protocol.rb - About 1 hr to fix

    Method parse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def parse(io)
        line = io.gets(TERMINATOR)

        case line[0]
        when SIMPLE_STRING
    Severity: Minor
    Found in lib/oxblood/protocol.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method georadius has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def georadius(key, longitude, latitude, radius, unit, opts = {})
    Severity: Minor
    Found in lib/oxblood/commands/geo.rb - About 45 mins to fix

      Method common_rangebyscore has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def common_rangebyscore(command_name, key, min, max, opts)
      Severity: Minor
      Found in lib/oxblood/commands/sorted_sets.rb - About 35 mins to fix

        Method common_store has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def common_store(command_name, destination, numkeys, *keys, **opts)
        Severity: Minor
        Found in lib/oxblood/commands/sorted_sets.rb - About 35 mins to fix

          Method common_range has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                def common_range(command_name, key, start, stop, opts)
          Severity: Minor
          Found in lib/oxblood/commands/sorted_sets.rb - About 35 mins to fix
            Severity
            Category
            Status
            Source
            Language