Sign upLogin

ethereum/mist

View on GitHub
Star

Showing 443 of 443 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      modalWindow.on('close', () => {
        BlurOverlay.disable();

        // user cancelled?
        if (!modalWindow.processed) {
Severity: Major
Found in modules/ipc/methods/eth_sendTransaction.js and 1 other location - About 1 hr to fix
modules/ipc/methods/eth_sendTransaction.js on lines 63..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      {
        label: i18n.t('mist.applicationMenu.develop.devToolsMistUI'),
        accelerator: 'Alt+CommandOrControl+I',
        click() {
          curWindow = BrowserWindow.getFocusedWindow();
Severity: Major
Found in modules/menuItems.js and 1 other location - About 1 hr to fix
modules/menuItems.js on lines 464..473

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if (callback) {
        if (!this.callbacks.connectAccount) {
          this.callbacks.connectAccount = [];
        }
        this.callbacks.connectAccount.push(callback);
Severity: Major
Found in modules/preloader/include/mistAPI.js and 1 other location - About 1 hr to fix
modules/preloader/injected/mistAPI.js on lines 61..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      if (callback) {
        if (!this.callbacks.connectAccount) {
          this.callbacks.connectAccount = [];
        }
        this.callbacks.connectAccount.push(callback);
Severity: Major
Found in modules/preloader/injected/mistAPI.js and 1 other location - About 1 hr to fix
modules/preloader/include/mistAPI.js on lines 51..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function message has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

window.addEventListener('message', function message(event) {
  let data;
  try {
    data = JSON.parse(event.data);
  } catch (e) {
Severity: Minor
Found in modules/preloader/browser.js - About 1 hr to fix

    Function pinToSidebar has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var pinToSidebar = function() {
  var selectedTab = TemplateVar.get('tab');

  if (selectedTab) {
    var existingUserTab = Helpers.getTabIdByUrl(selectedTab.url);
    Severity: Minor
    Found in interface/client/templates/popupWindows/connectAccount.js - About 1 hr to fix

      Function checkedUrl has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        checkedUrl: function() {
    var template = Template.instance();
    var tab = Tabs.findOne(this._id, { fields: { redirect: 1 } });
    var url;
      Severity: Minor
      Found in interface/client/templates/views/webview.js - About 1 hr to fix

        Function _resetSocket has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _resetSocket() {
    this._log.debug('Resetting socket');

    return Q.try(() => {
      if (STATE.CONNECTED === this._state) {
        Severity: Minor
        Found in modules/sockets/web3Ipc.js - About 1 hr to fix

          Function pinToSidebar has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          var pinToSidebar = function() {
  var selectedTab = TemplateVar.get('tab');

  if (selectedTab) {
    var existingUserTab = Helpers.getTabIdByUrl(selectedTab.url);
          Severity: Minor
          Found in interface/client/templates/popupWindows/connectAccount.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function renderDetails has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            renderDetails() {
    const { tx, etherPriceUSD } = this.props;

    if (!this.state.showDetails) {
      return (
          Severity: Minor
          Found in interface/components/TxHistory/TxRow.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _subscribeRemote has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _subscribeRemote(localSubscriptionId, params, retry = false) {
    return new Promise(async (resolve, reject) => {
      log.trace(
        `Creating remote subscription: ${params} (local subscription id: ${localSubscriptionId})`
      );
          Severity: Minor
          Found in modules/ipc/ipcProviderBackend.js - About 1 hr to fix

            Function add has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  add(id, options, callback) {
        const args = Array.prototype.slice.call(arguments);
        callback =
          typeof args[args.length - 1] === 'function' ? args.pop() : null;
        options = typeof args[args.length - 1] === 'object' ? args.pop() : null;
            Severity: Minor
            Found in modules/preloader/injected/mistAPI.js - About 1 hr to fix

              Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                render() {
    const { active, network, remote, local } = this.props;

    let mainClass = network == 'main' ? 'node-mainnet' : 'node-testnet';
    if (this.state.sticky) mainClass += ' sticky';
              Severity: Minor
              Found in interface/components/NodeInfo/index.js - About 1 hr to fix

                Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  render() {
    const txs = this.props.txs;

    const txList = txs.map(tx => {
      return (
                Severity: Minor
                Found in interface/components/TxHistory/index.js - About 1 hr to fix

                  Function constructor has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    constructor(mgr) {
    super();

    this._mgr = mgr;
    this._log = log.create('generic');
                  Severity: Minor
                  Found in modules/windows.js - About 1 hr to fix

                    Function drop .dropable has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      'drop .dropable': function(e, template) {
    e.preventDefault();

    if (e.originalEvent.dataTransfer) {
      files = e.originalEvent.dataTransfer.files;
                    Severity: Minor
                    Found in interface/client/templates/popupWindows/importAccount.js - About 1 hr to fix

                      Function render has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        render() {
    const appIconPath = `file://${window.dirname}/icons/${
      window.mistMode
    }/icon2x.png`;
    const appName = window.mistMode === 'mist' ? 'Mist' : 'Ethereum Wallet';
                      Severity: Minor
                      Found in interface/components/About.js - About 1 hr to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                const entry = {
          id: filteredId || 'mist_defaultId',
          position: options.position,
          selected: !!options.selected,
          name: options.name,
                        Severity: Major
                        Found in modules/preloader/injected/mistAPI.js and 1 other location - About 1 hr to fix
                        modules/preloader/include/mistAPI.js on lines 140..146

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 57.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                const entry = {
          id: filteredId || 'mist_defaultId',
          position: options.position,
          selected: !!options.selected,
          name: options.name,
                        Severity: Major
                        Found in modules/preloader/include/mistAPI.js and 1 other location - About 1 hr to fix
                        modules/preloader/injected/mistAPI.js on lines 157..163

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 57.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function removeListener has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          EventEmitter.prototype.removeListener = function removeListener(
    event,
    fn,
    context,
    once
                        Severity: Minor
                        Found in modules/preloader/injected/EventEmitter3.js - About 1 hr to fix
                          Severity
                          Category
                          Status
                          Source
                          Language