etnbrd/flx-lib

View on GitHub

Showing 18 of 18 total issues

Function retrocycle has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

function retrocycle($) {
    'use strict';

// Restore an object that was reduced by decycle. Members whose values are
// objects of the form
Severity: Minor
Found in lib/cycle.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function decycle has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

function decycle(object) {
    'use strict';

// Make a deep copy of an object or array, assuring that there is at most
// one instance of each object or array in the resulting structure. The
Severity: Minor
Found in lib/cycle.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {

  // Project configuration.
  grunt.initConfig({
    pkg: grunt.file.readJSON('package.json'),
Severity: Major
Found in gruntfile.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              if (item && typeof item === 'object') {
                path = item.$ref;
                if (typeof path === 'string' && px.test(path)) {
                  value[i] = eval(path);
                } else {
    Severity: Major
    Found in lib/cycle.js and 1 other location - About 1 hr to fix
    lib/cycle.js on lines 146..153

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (item) {
                  path = item.$ref;
                  if (typeof path === 'string' && px.test(path)) {
                    value[name] = eval(path);
                  } else {
    Severity: Major
    Found in lib/cycle.js and 1 other location - About 1 hr to fix
    lib/cycle.js on lines 133..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function decycle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function decycle(object) {
        'use strict';
    
    // Make a deep copy of an object or array, assuring that there is at most
    // one instance of each object or array in the resulting structure. The
    Severity: Minor
    Found in lib/cycle.js - About 1 hr to fix

      Function retrocycle has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function retrocycle($) {
          'use strict';
      
      // Restore an object that was reduced by decycle. Members whose values are
      // objects of the form
      Severity: Minor
      Found in lib/cycle.js - About 1 hr to fix

        Function derez has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          return (function derez(value, path) {
        
        // The derez recurses through the object, producing the deep copy.
        
            var i,          // The loop counter
        Severity: Minor
        Found in lib/cycle.js - About 1 hr to fix

          Function rez has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            (function rez(value) {
          
          // The rez function walks recursively through the object looking for $ref
          // properties. When it finds one that has a value that is a path, then it
          // replaces the $ref object with a reference to the value that is found by
          Severity: Minor
          Found in lib/cycle.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                if (typeof value === 'object' && value !== null &&
                    !(value instanceof Boolean) &&
                    !(value instanceof Date) &&
                    !(value instanceof Number) &&
                    !(value instanceof RegExp) &&
            Severity: Major
            Found in lib/cycle.js - About 1 hr to fix

              Function register has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              function register(name, fn, scp, remote) {
                if (flxRepo[name] && !options.allowFlxOverwrite)
                  return false;
              
                if (typeof fn === 'function') {
              Severity: Minor
              Found in lib/index.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                          if (item) {
                            path = item.$ref;
                            if (typeof path === 'string' && px.test(path)) {
                              value[name] = eval(path);
                            } else {
              Severity: Major
              Found in lib/cycle.js - About 45 mins to fix

                Function bootstrapMinions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function bootstrapMinions() {
                
                  /* Warning, there might be a race condition in this fonction.
                     I don't now if fork is synchronous or not, and I can't find anythin on the web.
                     If it is synchronous, there is no race condition, but poor performance are to be expected.
                Severity: Minor
                Found in lib/index.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function receive has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                function receive(req) {
                  function _receiveOne(dest) {
                    if (!flxRepo[dest]) {
                      throw 'flx ' + dest + ' is not defined';
                    }
                Severity: Minor
                Found in lib/index.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid deeply nested control flow statements.
                Open

                            if (typeof path === 'string' && px.test(path)) {
                              value[i] = eval(path);
                            } else {
                              rez(item);
                            }
                Severity: Major
                Found in lib/cycle.js - About 45 mins to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if (Array.isArray(req.dest)) {
                      req.dest.forEach(_receiveOne)
                    } else {
                      _receiveOne(req.dest);
                    }
                  Severity: Minor
                  Found in lib/index.js and 1 other location - About 40 mins to fix
                  lib/minion.js on lines 59..63

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if (Array.isArray(req.dest)) {
                      req.dest.forEach(_receiveOne);
                    } else {
                      _receiveOne(req.dest);
                    }
                  Severity: Minor
                  Found in lib/minion.js and 1 other location - About 40 mins to fix
                  lib/index.js on lines 77..81

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function serializeObject has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function serializeObject(obj) {
                    for (name in obj) { var value = obj[name];
                      if (isFunction(value)) {
                        obj[name] = {__dryfn: true, fn: serializeFn(value)};
                      }
                  Severity: Minor
                  Found in lib/index.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language