Sign upLogin

etnbrd/flx-lib

View on GitHub
Star
lib/cycle.js

Summary

Maintainability
D
2 days
Test Coverage

Function retrocycle has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
Open

function retrocycle($) {
    'use strict';

// Restore an object that was reduced by decycle. Members whose values are
// objects of the form
Severity: Minor
Found in lib/cycle.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function decycle has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

function decycle(object) {
    'use strict';

// Make a deep copy of an object or array, assuring that there is at most
// one instance of each object or array in the resulting structure. The
Severity: Minor
Found in lib/cycle.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function decycle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function decycle(object) {
    'use strict';

// Make a deep copy of an object or array, assuring that there is at most
// one instance of each object or array in the resulting structure. The
Severity: Minor
Found in lib/cycle.js - About 1 hr to fix

    Function retrocycle has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function retrocycle($) {
    'use strict';

// Restore an object that was reduced by decycle. Members whose values are
// objects of the form
    Severity: Minor
    Found in lib/cycle.js - About 1 hr to fix

      Function derez has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        return (function derez(value, path) {

// The derez recurses through the object, producing the deep copy.

    var i,          // The loop counter
      Severity: Minor
      Found in lib/cycle.js - About 1 hr to fix

        Function rez has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          (function rez(value) {

// The rez function walks recursively through the object looking for $ref
// properties. When it finds one that has a value that is a path, then it
// replaces the $ref object with a reference to the value that is found by
        Severity: Minor
        Found in lib/cycle.js - About 1 hr to fix

          Consider simplifying this complex logical expression.
          Open

              if (typeof value === 'object' && value !== null &&
        !(value instanceof Boolean) &&
        !(value instanceof Date) &&
        !(value instanceof Number) &&
        !(value instanceof RegExp) &&
          Severity: Major
          Found in lib/cycle.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                        if (item) {
              path = item.$ref;
              if (typeof path === 'string' && px.test(path)) {
                value[name] = eval(path);
              } else {
            Severity: Major
            Found in lib/cycle.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if (typeof path === 'string' && px.test(path)) {
              value[i] = eval(path);
            } else {
              rez(item);
            }
              Severity: Major
              Found in lib/cycle.js - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (item && typeof item === 'object') {
            path = item.$ref;
            if (typeof path === 'string' && px.test(path)) {
              value[i] = eval(path);
            } else {
                Severity: Major
                Found in lib/cycle.js and 1 other location - About 1 hr to fix
                lib/cycle.js on lines 146..153

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (item) {
              path = item.$ref;
              if (typeof path === 'string' && px.test(path)) {
                value[name] = eval(path);
              } else {
                Severity: Major
                Found in lib/cycle.js and 1 other location - About 1 hr to fix
                lib/cycle.js on lines 133..140

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status