Sign upLogin

etsy/411

View on GitHub
Star

Showing 370 of 370 total issues

Avoid too many return statements within this function.
Open

                return tokenize(stream, state);
Severity: Major
Found in htdocs/assets/js/views/searches/syntax/ecl.js - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return self::format($this->update($get, $data));
    Severity: Major
    Found in phplib/REST/Alerts.php - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                return token_(state, "keyword");
      Severity: Major
      Found in htdocs/assets/js/views/searches/syntax/elasticsearch.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return tok;
        Severity: Major
        Found in htdocs/assets/js/views/searches/syntax/elasticsearch.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return token_(state, "bracket");
          Severity: Major
          Found in htdocs/assets/js/views/searches/syntax/elasticsearch.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return token_(state, "meta");
            Severity: Major
            Found in htdocs/assets/js/views/searches/syntax/elasticsearch.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return 'bracket';
              Severity: Major
              Found in htdocs/assets/js/views/searches/syntax/elasticsearch.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return token_error(stream, state);
                Severity: Major
                Found in htdocs/assets/js/views/searches/syntax/elasticsearch.js - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return;
                  Severity: Major
                  Found in phplib/Cookie.php - About 30 mins to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            selectAction: function(action) {
            switch(action) {
                case 'open': this.toggleEdit(); break;
                case 'delete': this.delete(); break;
            }
                    Severity: Minor
                    Found in htdocs/assets/js/views/alerts/alert.js and 2 other locations - About 30 mins to fix
                    htdocs/assets/js/views/searches/searches.js on lines 198..203
                    htdocs/assets/js/views/searches/searches.js on lines 264..269

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                _.extend(vars, {
                new_group: this.model.isNew(),
                types: Group.Data().Types
            });
                    Severity: Minor
                    Found in htdocs/assets/js/views/groups/group.js and 2 other locations - About 30 mins to fix
                    htdocs/assets/js/views/lists/list.js on lines 57..60
                    htdocs/assets/js/views/reports/report.js on lines 123..126

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                _.extend(vars, {
                new_report: this.model.isNew(),
                types: Report.Data().Types
            });
                    Severity: Minor
                    Found in htdocs/assets/js/views/reports/report.js and 2 other locations - About 30 mins to fix
                    htdocs/assets/js/views/groups/group.js on lines 139..142
                    htdocs/assets/js/views/lists/list.js on lines 57..60

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                                _.extend(vars, {
                new_list: this.model.isNew(),
                types: List.Data().Types
            });
                    Severity: Minor
                    Found in htdocs/assets/js/views/lists/list.js and 2 other locations - About 30 mins to fix
                    htdocs/assets/js/views/groups/group.js on lines 139..142
                    htdocs/assets/js/views/reports/report.js on lines 123..126

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            initialize: function(options) {
            ModalView.prototype.initialize.call(this);
            this.alerts = options.alerts;
        },
                    Severity: Minor
                    Found in htdocs/assets/js/views/alerts/actions.js and 1 other location - About 30 mins to fix
                    htdocs/assets/js/views/alerts/actions.js on lines 20..23

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                            initialize: function(options) {
            ModalView.prototype.initialize.call(this);
            this.alerts = options.alerts;
        },
                    Severity: Minor
                    Found in htdocs/assets/js/views/alerts/actions.js and 1 other location - About 30 mins to fix
                    htdocs/assets/js/views/alerts/actions.js on lines 86..89

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            selectAction: function(action) {
            switch(action) {
                case 'open': this.open(); break;
                case 'clone': this.clone(); break;
            }
                    Severity: Minor
                    Found in htdocs/assets/js/views/searches/searches.js and 2 other locations - About 30 mins to fix
                    htdocs/assets/js/views/alerts/alert.js on lines 182..187
                    htdocs/assets/js/views/searches/searches.js on lines 198..203

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                            selectAction: function(action) {
            switch(action) {
                case 'open': this.open(); break;
                case 'clone': this.clone(); break;
            }
                    Severity: Minor
                    Found in htdocs/assets/js/views/searches/searches.js and 2 other locations - About 30 mins to fix
                    htdocs/assets/js/views/alerts/alert.js on lines 182..187
                    htdocs/assets/js/views/searches/searches.js on lines 264..269

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function PUT has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function PUT(array $get, array $data) {
        $target_id = (int) Util::get($get, 'id');
        // Only an admin user or the user themself should be able to modify a user!
        // That check is done here. Note that the strict compare is necessary as getUserId()
        // can return null.
                    Severity: Minor
                    Found in phplib/REST/Users.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function process has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function process(Alert $alert, $date) {
        $data = $this->obj['data'];
        $key_regex = Util::get($data, 'key_regex', '');
        $expression = Util::get($data, 'key_expr', '');
        $keys = array_keys($alert['content']);
                    Severity: Minor
                    Found in phplib/Filter/MapKey.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function execute($get, $data) {
        if(!$this->allowCreate()) {
            throw new ForbiddenException;
        }
                    Severity: Minor
                    Found in phplib/REST/Searches.php - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language