Sign upLogin

etsy/411

View on GitHub
Star
phplib/Job/Search.php

Summary

Maintainability
C
1 day
Test Coverage

Function _run has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public function _run($commit, Search $search, $disable_search_commit=false) {
        $alerts = [];
        $errors = [];

        // Don't allow saving Alerts if the Search isn't in the DB.
Severity: Minor
Found in phplib/Job/Search.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _run has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function _run($commit, Search $search, $disable_search_commit=false) {
        $alerts = [];
        $errors = [];

        // Don't allow saving Alerts if the Search isn't in the DB.
Severity: Major
Found in phplib/Job/Search.php - About 3 hrs to fix

    Function processTargets has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function processTargets(array $alerts, array $targets, $date) {
        $errors = [];
        foreach($targets as $target) {
            // Call process on each Target -> Alert.
            foreach($alerts as $alert) {
    Severity: Minor
    Found in phplib/Job/Search.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function processFilters has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function processFilters(array $alerts, array $filters, $date) {
        $errors = [];

        foreach($filters as $filter) {
            $new_alerts = [];
    Severity: Minor
    Found in phplib/Job/Search.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status