Sign upLogin

etsy/411

View on GitHub
Star
phplib/REST/Models.php

Summary

Maintainability
C
1 day
Test Coverage

Function update has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function update($get, $data, $set_fields=[]) {
        if(!$this->allowUpdate()) {
            throw new ForbiddenException;
        }
        $id = Util::get($get, 'id');
Severity: Minor
Found in phplib/REST/Models.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function update($get, $data, $set_fields=[]) {
        if(!$this->allowUpdate()) {
            throw new ForbiddenException;
        }
        $id = Util::get($get, 'id');
Severity: Major
Found in phplib/REST/Models.php - About 3 hrs to fix

    Method read has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function read($data) {
        if(!$this->allowRead()) {
            throw new ForbiddenException;
        }
    Severity: Minor
    Found in phplib/REST/Models.php - About 1 hr to fix

      Function read has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function read($data) {
        if(!$this->allowRead()) {
            throw new ForbiddenException;
        }
      Severity: Minor
      Found in phplib/REST/Models.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function filterByKeys has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function filterByKeys($keys, $srcs) {
        $ret = [];
        foreach($keys as $key) {
            foreach($srcs as $src) {
                if(Util::exists($src, $key)) {
      Severity: Minor
      Found in phplib/REST/Models.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status