Sign upLogin

etsy/411

View on GitHub
Star
phplib/REST/Searches.php

Summary

Maintainability
C
1 day
Test Coverage

Method stats has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function stats($data) {
        if(!$this->allowRead()) {
            throw new ForbiddenException;
        }
Severity: Major
Found in phplib/REST/Searches.php - About 2 hrs to fix

    Method preview has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function preview($get, $data) {
        if(!$this->allowCreate()) {
            throw new ForbiddenException;
        }
    Severity: Minor
    Found in phplib/REST/Searches.php - About 1 hr to fix

      Method afterStore has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function afterStore($model, $data, $new, $delete) {
        $fields = ['tags', 'priority', 'category', 'owner'];

        // Trigger a job to delete all Alerts if the Search was deleted.
        if($delete) {
      Severity: Minor
      Found in phplib/REST/Searches.php - About 1 hr to fix

        Function afterStore has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function afterStore($model, $data, $new, $delete) {
        $fields = ['tags', 'priority', 'category', 'owner'];

        // Trigger a job to delete all Alerts if the Search was deleted.
        if($delete) {
        Severity: Minor
        Found in phplib/REST/Searches.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method test has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function test($get, $data) {
        if(!$this->allowCreate()) {
            throw new ForbiddenException;
        }
        Severity: Minor
        Found in phplib/REST/Searches.php - About 1 hr to fix

          Function preview has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function preview($get, $data) {
        if(!$this->allowCreate()) {
            throw new ForbiddenException;
        }
          Severity: Minor
          Found in phplib/REST/Searches.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function test has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function test($get, $data) {
        if(!$this->allowCreate()) {
            throw new ForbiddenException;
        }
          Severity: Minor
          Found in phplib/REST/Searches.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function execute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function execute($get, $data) {
        if(!$this->allowCreate()) {
            throw new ForbiddenException;
        }
          Severity: Minor
          Found in phplib/REST/Searches.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status