Sign upLogin

etsy/411

View on GitHub
Star
phplib/Scheduler.php

Summary

Maintainability
D
1 day
Test Coverage

Function backfill has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function backfill($start_date, $end_date, $max_jobs=5) {
        Logger::info('Scheduler backfill run', ['start' => $start_date, 'end' => $end_date], self::LOG_NAMESPACE);
        cli_set_process_title('411] Backfill');
        print "[+] Backfill: $start_date to $end_date\n";
        $timer = new Timer();
Severity: Minor
Found in phplib/Scheduler.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processSite has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function processSite($site, $date, $backfill) {
        Logger::info('Process site', ['id' => $site['id'], 'date' => $date, 'backfill' => $backfill], self::LOG_NAMESPACE);
        $base_title = sprintf('411] Time: %d Site: %d', $date, $site['id']);
        cli_set_process_title($base_title);
        $timer = new Timer();
Severity: Minor
Found in phplib/Scheduler.php - About 1 hr to fix

    Method backfill has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function backfill($start_date, $end_date, $max_jobs=5) {
        Logger::info('Scheduler backfill run', ['start' => $start_date, 'end' => $end_date], self::LOG_NAMESPACE);
        cli_set_process_title('411] Backfill');
        print "[+] Backfill: $start_date to $end_date\n";
        $timer = new Timer();
    Severity: Minor
    Found in phplib/Scheduler.php - About 1 hr to fix

      Function process has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function process($date, $backfill) {
        Logger::info('Scheduler run', ['time' => $date], self::LOG_NAMESPACE);
        cli_set_process_title('411] Scheduler');
        print "[+] Scheduler: $date\n";
        $timer = new Timer();
      Severity: Minor
      Found in phplib/Scheduler.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function process($date, $backfill) {
        Logger::info('Scheduler run', ['time' => $date], self::LOG_NAMESPACE);
        cli_set_process_title('411] Scheduler');
        print "[+] Scheduler: $date\n";
        $timer = new Timer();
      Severity: Minor
      Found in phplib/Scheduler.php - About 1 hr to fix

        Function health has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            private function health($date) {
        $search_health = [];

        $cfg = new DBConfig;
        $meta = new DBMeta;
        Severity: Minor
        Found in phplib/Scheduler.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function processSearches has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function processSearches($date, $search_health, $backfill) {
        foreach(SearchFinder::getByQuery(['enabled' => 1]) as $search) {
            // If the search doesn't need to run OR
            // the search type is failing and isn't time based
            // skip it!
        Severity: Minor
        Found in phplib/Scheduler.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function processSite has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function processSite($site, $date, $backfill) {
        Logger::info('Process site', ['id' => $site['id'], 'date' => $date, 'backfill' => $backfill], self::LOG_NAMESPACE);
        $base_title = sprintf('411] Time: %d Site: %d', $date, $site['id']);
        cli_set_process_title($base_title);
        $timer = new Timer();
        Severity: Minor
        Found in phplib/Scheduler.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if(is_null($lastjob) || $date - $lastjob['target_date'] >= 1 * 60 * 60 - 5) {
            $rollupjob = new Rollup_Job();
            $rollupjob['target_id'] = Rollup_Job::I_HOURLY;
            $rollupjob['target_date'] = $date;
            $rollupjob->store();
        Severity: Major
        Found in phplib/Scheduler.php and 1 other location - About 1 hr to fix
        phplib/Scheduler.php on lines 200..207

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if(is_null($lastjob) || $date - $lastjob['target_date'] >= 24 * 60 * 60 - 5) {
            $rollupjob = new Rollup_Job();
            $rollupjob['target_id'] = Rollup_Job::I_DAILY;
            $rollupjob['target_date'] = $date;
            $rollupjob->store();
        Severity: Major
        Found in phplib/Scheduler.php and 1 other location - About 1 hr to fix
        phplib/Scheduler.php on lines 189..196

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 111.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private function processCleanup($date) {
        // Run daily.
        $lastjob = JobFinder::getLastByQuery(['type' => Cleanup_Job::$TYPE]);
        if(is_null($lastjob) || $date - $lastjob['target_date'] >= 24 * 60 * 60 - 5) {
            $cleanupjob = new Cleanup_Job();
        Severity: Minor
        Found in phplib/Scheduler.php and 1 other location - About 35 mins to fix
        phplib/Scheduler.php on lines 265..273

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            private function processAutoclose($date, $backfill) {
        // Run hourly.
        $lastjob = JobFinder::getLastByQuery(['type' => Autoclose_Job::$TYPE]);
        if(is_null($lastjob) || $date - $lastjob['target_date'] >= 1 * 60 * 60 - 5) {
            $autoclosejob = new Autoclose_Job();
        Severity: Minor
        Found in phplib/Scheduler.php and 1 other location - About 35 mins to fix
        phplib/Scheduler.php on lines 279..287

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 92.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status