Sign upLogin

etsy/411

View on GitHub
Star
phplib/Search.php

Summary

Maintainability
C
1 day
Test Coverage

File Search.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace FOO;

/**
Severity: Minor
Found in phplib/Search.php - About 2 hrs to fix

    Search has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    abstract class Search extends TypeModel {
    public static $TYPES = [
        Null_Search::class,
        ES_Search::class,
        ECL_Search::class,
    Severity: Minor
    Found in phplib/Search.php - About 2 hrs to fix

      Function validateData has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          public function validateData(array $data) {
        parent::validateData($data);

        if(strlen(trim($data['name'])) == 0) {
            throw new ValidationException('Invalid name');
      Severity: Minor
      Found in phplib/Search.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method validateData has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function validateData(array $data) {
        parent::validateData($data);

        if(strlen(trim($data['name'])) == 0) {
            throw new ValidationException('Invalid name');
      Severity: Minor
      Found in phplib/Search.php - About 1 hr to fix

        Method generateSchema has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected static function generateSchema() {
        return [
            'name' => [self::T_STR, null, ''],
            'source' => [self::T_STR, null, ''],
            'query_data' => [self::T_OBJ, null, []],
        Severity: Minor
        Found in phplib/Search.php - About 1 hr to fix

          Function shouldRun has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function shouldRun($date, $backfill=false) {
        $due = false;
        $job = JobFinder::getLastByQuery(['type' => Search_Job::$TYPE, 'target_id' => $this->obj[static::$PKEY]]);

        $last_scheduled_date = is_null($job) ? 0:$job['target_date'];
          Severity: Minor
          Found in phplib/Search.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status