Sign upLogin

etsy/411

View on GitHub
Star
phplib/Search/ECL.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function _execute has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _execute($date, $constructed_qdata) {
        // If our last_success_date is within 10 seconds of the start time, use that
        // as the start time.
        $from = $date - ($this->obj['range'] * 60);
        if(abs($this->obj['last_success_date'] - $from) < 10) {
Severity: Minor
Found in phplib/Search/ECL.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _execute has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _execute($date, $constructed_qdata) {
        // If our last_success_date is within 10 seconds of the start time, use that
        // as the start time.
        $from = $date - ($this->obj['range'] * 60);
        if(abs($this->obj['last_success_date'] - $from) < 10) {
Severity: Minor
Found in phplib/Search/ECL.php - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status