Sign upLogin

etsy/phan

View on GitHub
Star
.phan/plugins/DuplicateExpressionPlugin.php

Summary

Maintainability
F
3 days
Test Coverage

File DuplicateExpressionPlugin.php has 418 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

use ast\flags;
Severity: Minor
Found in .phan/plugins/DuplicateExpressionPlugin.php - About 6 hrs to fix

    The class RedundantNodePostAnalysisVisitor has an overall complexity of 55 which is very high. The configured complexity threshold is 50.
    Open

    class RedundantNodePostAnalysisVisitor extends PluginAwarePostAnalysisVisitor
{
    /**
     * These are types of binary operations for which it is
     * likely to be a typo if both the left and right-hand sides
    Severity: Minor
    Found in .phan/plugins/DuplicateExpressionPlugin.php by phpmd

    Method visitBinaryOp has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function visitBinaryOp(Node $node): void
    {
        $flags = $node->flags;
        if (!\array_key_exists($flags, self::REDUNDANT_BINARY_OP_SET)) {
            // Nothing to warn about
    Severity: Major
    Found in .phan/plugins/DuplicateExpressionPlugin.php - About 2 hrs to fix

      Method visitAssign has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function visitAssign(Node $node): void
    {
        $expr = $node->children['expr'];
        if (!$expr instanceof Node) {
            // Guaranteed not to contain duplicate expressions in valid php assignments.
      Severity: Minor
      Found in .phan/plugins/DuplicateExpressionPlugin.php - About 1 hr to fix

        Function visitAssign has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            public function visitAssign(Node $node): void
    {
        $expr = $node->children['expr'];
        if (!$expr instanceof Node) {
            // Guaranteed not to contain duplicate expressions in valid php assignments.
        Severity: Minor
        Found in .phan/plugins/DuplicateExpressionPlugin.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method visitIf has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function visitIf(Node $node): void
    {
        if (count($node->children) <= 1) {
            // There can't be any duplicates.
            return;
        Severity: Minor
        Found in .phan/plugins/DuplicateExpressionPlugin.php - About 1 hr to fix

          Method visitConditional has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function visitConditional(Node $node): void
    {
        $cond_node = $node->children['cond'];
        $true_node_hash = ASTHasher::hash($node->children['true']);
          Severity: Minor
          Found in .phan/plugins/DuplicateExpressionPlugin.php - About 1 hr to fix

            Function visitIf has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function visitIf(Node $node): void
    {
        if (count($node->children) <= 1) {
            // There can't be any duplicates.
            return;
            Severity: Minor
            Found in .phan/plugins/DuplicateExpressionPlugin.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function visitBinaryOp has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function visitBinaryOp(Node $node): void
    {
        $flags = $node->flags;
        if (!\array_key_exists($flags, self::REDUNDANT_BINARY_OP_SET)) {
            // Nothing to warn about
            Severity: Minor
            Found in .phan/plugins/DuplicateExpressionPlugin.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function checkUnaryOpOfConditional has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                private function checkUnaryOpOfConditional(Node $cond_node, $true_node_hash): void
    {
        if ($cond_node->flags !== ast\flags\UNARY_BOOL_NOT) {
            return;
        }
            Severity: Minor
            Found in .phan/plugins/DuplicateExpressionPlugin.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function extractIfElseifChain has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private static function extractIfElseifChain(Node $node): array
    {
        $children = $node->children;
        if (count($children) <= 1) {
            return $children;
            Severity: Minor
            Found in .phan/plugins/DuplicateExpressionPlugin.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function visitConditional has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function visitConditional(Node $node): void
    {
        $cond_node = $node->children['cond'];
        $true_node_hash = ASTHasher::hash($node->children['true']);
            Severity: Minor
            Found in .phan/plugins/DuplicateExpressionPlugin.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function checkBinaryOpOfConditional has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function checkBinaryOpOfConditional(Node $cond_node, $true_node_hash): void
    {
        if ($cond_node->flags !== ast\flags\BINARY_IS_NOT_IDENTICAL) {
            return;
        }
            Severity: Minor
            Found in .phan/plugins/DuplicateExpressionPlugin.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                            return;
            Severity: Major
            Found in .phan/plugins/DuplicateExpressionPlugin.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return $node;
              Severity: Major
              Found in .phan/plugins/DuplicateExpressionPlugin.php - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private const BINARY_OP_BOTH_LITERAL_WARN_SET = [
        flags\BINARY_BOOL_AND            => true,
        flags\BINARY_BOOL_OR             => true,
        flags\BINARY_BOOL_XOR            => true,
        flags\BINARY_IS_IDENTICAL        => true,
                Severity: Major
                Found in .phan/plugins/DuplicateExpressionPlugin.php and 1 other location - About 3 hrs to fix
                src/Phan/Analysis/PostOrderAnalysisVisitor.php on lines 721..735

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 150.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    private const ASSIGN_OP_FLAGS = [
        flags\BINARY_BITWISE_OR => '|',
        flags\BINARY_BITWISE_AND => '&',
        flags\BINARY_BITWISE_XOR => '^',
        flags\BINARY_CONCAT => '.',
                Severity: Major
                Found in .phan/plugins/DuplicateExpressionPlugin.php and 1 other location - About 1 hr to fix
                src/Phan/Debug.php on lines 351..365

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid variables with short names like $N. Configured minimum length is 3.
                Open

                        $N = count($children);
                Severity: Minor
                Found in .phan/plugins/DuplicateExpressionPlugin.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                Avoid variables with short names like $n. Configured minimum length is 3.
                Open

                        $n = count($catches);
                Severity: Minor
                Found in .phan/plugins/DuplicateExpressionPlugin.php by phpmd

                ShortVariable

                Since: 0.2

                Detects when a field, local, or parameter has a very short name.

                Example

                class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

                Source https://phpmd.org/rules/naming.html#shortvariable

                There are no issues that match your filters.

                Category
                Status