Sign upLogin

etsy/phan

View on GitHub
Star
.phan/plugins/InlineHTMLPlugin.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function afterAnalyzeFile has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function afterAnalyzeFile(
        CodeBase $code_base,
        Context $context,
        string $file_contents,
        Node $node
Severity: Minor
Found in .phan/plugins/InlineHTMLPlugin.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method afterAnalyzeFile has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function afterAnalyzeFile(
        CodeBase $code_base,
        Context $context,
        string $file_contents,
        Node $node
Severity: Minor
Found in .phan/plugins/InlineHTMLPlugin.php - About 1 hr to fix

    Method warnAboutInlineHTML has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        private function warnAboutInlineHTML(CodeBase $code_base, Context $context, array $token, int $i, int $n): void
    Severity: Minor
    Found in .phan/plugins/InlineHTMLPlugin.php - About 35 mins to fix

      Avoid variables with short names like $i. Configured minimum length is 3.
      Open

          private function warnAboutInlineHTML(CodeBase $code_base, Context $context, array $token, int $i, int $n): void
      Severity: Minor
      Found in .phan/plugins/InlineHTMLPlugin.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $n. Configured minimum length is 3.
      Open

          private function warnAboutInlineHTML(CodeBase $code_base, Context $context, array $token, int $i, int $n): void
      Severity: Minor
      Found in .phan/plugins/InlineHTMLPlugin.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $N. Configured minimum length is 3.
      Open

                  $N = count($tokens);
      Severity: Minor
      Found in .phan/plugins/InlineHTMLPlugin.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      Constant InlineHTMLLeading should be defined in uppercase
      Open

          private const InlineHTMLLeading = 'PhanPluginInlineHTMLLeading';
      Severity: Minor
      Found in .phan/plugins/InlineHTMLPlugin.php by phpmd

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant InlineHTMLTrailing should be defined in uppercase
      Open

          private const InlineHTMLTrailing = 'PhanPluginInlineHTMLTrailing';
      Severity: Minor
      Found in .phan/plugins/InlineHTMLPlugin.php by phpmd

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant InlineHTML should be defined in uppercase
      Open

          private const InlineHTML = 'PhanPluginInlineHTML';
      Severity: Minor
      Found in .phan/plugins/InlineHTMLPlugin.php by phpmd

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      There are no issues that match your filters.

      Category
      Status