.phan/plugins/MoreSpecificElementTypePlugin.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function shouldWarnAboutMoreSpecificType has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    private static function shouldWarnAboutMoreSpecificType(CodeBase $code_base, UnionType $actual_type, UnionType $declared_return_type): bool
    {
        if ($declared_return_type->isEmpty()) {
            // There was no phpdoc type declaration, so let UnknownElementTypePlugin warn about that instead of this.
            // This plugin warns about `@return mixed` but not the absence of a declaration because the former normally prevents phan from inferring something more specific.
Severity: Minor
Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method shouldWarnAboutMoreSpecificType has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function shouldWarnAboutMoreSpecificType(CodeBase $code_base, UnionType $actual_type, UnionType $declared_return_type): bool
    {
        if ($declared_return_type->isEmpty()) {
            // There was no phpdoc type declaration, so let UnknownElementTypePlugin warn about that instead of this.
            // This plugin warns about `@return mixed` but not the absence of a declaration because the former normally prevents phan from inferring something more specific.
Severity: Minor
Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 1 hr to fix

    Method finalizeProcess has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function finalizeProcess(CodeBase $code_base): void
        {
            foreach (self::$method_return_types as $type_info) {
                $function = $type_info->function;
                $function_context = $function->getContext();
    Severity: Minor
    Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 1 hr to fix

      Function finalizeProcess has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function finalizeProcess(CodeBase $code_base): void
          {
              foreach (self::$method_return_types as $type_info) {
                  $function = $type_info->function;
                  $function_context = $function->getContext();
      Severity: Minor
      Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function visitReturn has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function visitReturn(Node $node): void
          {
              if (!$this->context->isInFunctionLikeScope()) {
                  return;
              }
      Severity: Minor
      Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return;
            Severity: Major
            Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return false;
              Severity: Major
              Found in .phan/plugins/MoreSpecificElementTypePlugin.php - About 30 mins to fix

                The method shouldWarnAboutMoreSpecificType() has an NPath complexity of 576. The configured NPath complexity threshold is 200.
                Open

                    private static function shouldWarnAboutMoreSpecificType(CodeBase $code_base, UnionType $actual_type, UnionType $declared_return_type): bool
                    {
                        if ($declared_return_type->isEmpty()) {
                            // There was no phpdoc type declaration, so let UnknownElementTypePlugin warn about that instead of this.
                            // This plugin warns about `@return mixed` but not the absence of a declaration because the former normally prevents phan from inferring something more specific.

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                The method shouldWarnAboutMoreSpecificType() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                Open

                    private static function shouldWarnAboutMoreSpecificType(CodeBase $code_base, UnionType $actual_type, UnionType $declared_return_type): bool
                    {
                        if ($declared_return_type->isEmpty()) {
                            // There was no phpdoc type declaration, so let UnknownElementTypePlugin warn about that instead of this.
                            // This plugin warns about `@return mixed` but not the absence of a declaration because the former normally prevents phan from inferring something more specific.

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                There are no issues that match your filters.

                Category
                Status