Sign upLogin

etsy/phan

View on GitHub
Star
internal/lib/NotFullyQualifiedReporterPlugin.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function finalizeProcess has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function finalizeProcess(CodeBase $code_base): void
    {
        echo "<" . "?php declare(strict_types=1);\n";
        ksort(self::$calls);
        foreach (self::$calls as $namespace => $name_set) {
Severity: Minor
Found in internal/lib/NotFullyQualifiedReporterPlugin.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method finalizeProcess has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function finalizeProcess(CodeBase $code_base): void
    {
        echo "<" . "?php declare(strict_types=1);\n";
        ksort(self::$calls);
        foreach (self::$calls as $namespace => $name_set) {
Severity: Minor
Found in internal/lib/NotFullyQualifiedReporterPlugin.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return;
    Severity: Major
    Found in internal/lib/NotFullyQualifiedReporterPlugin.php - About 30 mins to fix

      Function visitCall has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function visitCall(Node $node): void
    {
        $expression = $node->children['expr'];
        if (!($expression instanceof Node) || $expression->kind !== ast\AST_NAME) {
            return;
      Severity: Minor
      Found in internal/lib/NotFullyQualifiedReporterPlugin.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method finalizeProcess() contains an exit expression.
      Open

              exit(0);
      Severity: Minor
      Found in internal/lib/NotFullyQualifiedReporterPlugin.php by phpmd

      ExitExpression

      Since: 0.2

      An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

      Example

      class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

      Source https://phpmd.org/rules/design.html#exitexpression

      Avoid variables with short names like $rf. Configured minimum length is 3.
      Open

                      $rf = new ReflectionFunction($function_name);
      Severity: Minor
      Found in internal/lib/NotFullyQualifiedReporterPlugin.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status