Sign upLogin

etsy/phan

View on GitHub
Star
internal/line_deleter.php

Summary

Maintainability
A
55 mins
Test Coverage

Function getLinesToDelete has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getLinesToDelete(string $file_contents): array
    {
        $paths = [];
        foreach (explode("\n", $file_contents) as $line) {
            $line = trim($line);
Severity: Minor
Found in internal/line_deleter.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method main() contains an exit expression.
Open

            exit(1);
Severity: Minor
Found in internal/line_deleter.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method main() contains an exit expression.
Open

            exit(0);
Severity: Minor
Found in internal/line_deleter.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

The method main() contains an exit expression.
Open

            exit(1);
Severity: Minor
Found in internal/line_deleter.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

There are no issues that match your filters.

Category
Status