Sign upLogin

etsy/phan

View on GitHub
Star
internal/sanitycheck.php

Summary

Maintainability
D
3 days
Test Coverage

Function check_fields has a Cognitive Complexity of 81 (exceeds 5 allowed). Consider refactoring.
Open

function check_fields(string $function_name, array $fields, array $signatures): void
{
    $return_type = $fields[0];  // TODO: Check type
    if (!is_string($return_type)) {
        throw new InvalidArgumentException("Invalid return type: " . json_encode($return_type));
Severity: Minor
Found in internal/sanitycheck.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_fields has 164 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function check_fields(string $function_name, array $fields, array $signatures): void
{
    $return_type = $fields[0];  // TODO: Check type
    if (!is_string($return_type)) {
        throw new InvalidArgumentException("Invalid return type: " . json_encode($return_type));
Severity: Major
Found in internal/sanitycheck.php - About 6 hrs to fix

    File sanitycheck.php has 294 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    #!/usr/bin/env php
<?php

declare(strict_types=1);
    Severity: Minor
    Found in internal/sanitycheck.php - About 3 hrs to fix

      Function getParametersCountsFromPhan has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      function getParametersCountsFromPhan(array $fields): array
{
    $num_required = 0;
    unset($fields[0]);
    $num_optional = count($fields);
      Severity: Minor
      Found in internal/sanitycheck.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getPhanSignatureArrayFromReflection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function getPhanSignatureArrayFromReflection(ReflectionFunctionAbstract $function): array
{
    $return_type = $function->getReturnType();
    $return_type_representation = getUnionTypeStringForReflectionType($return_type);
    $result = [0 => $return_type_representation];
      Severity: Minor
      Found in internal/sanitycheck.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getParameterCountsFromReflection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function getParameterCountsFromReflection(array $args): array
{
    $num_required = 0;
    $num_optional = count($args);
    foreach ($args as $reflection_parameter) {
      Severity: Minor
      Found in internal/sanitycheck.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The function check_fields() has 184 lines of code. Current threshold is set to 100. Avoid really long methods.
      Open

      function check_fields(string $function_name, array $fields, array $signatures): void
{
    $return_type = $fields[0];  // TODO: Check type
    if (!is_string($return_type)) {
        throw new InvalidArgumentException("Invalid return type: " . json_encode($return_type));
      Severity: Minor
      Found in internal/sanitycheck.php by phpmd

      The function check_fields() has an NPath complexity of 1189728. The configured NPath complexity threshold is 200.
      Open

      function check_fields(string $function_name, array $fields, array $signatures): void
{
    $return_type = $fields[0];  // TODO: Check type
    if (!is_string($return_type)) {
        throw new InvalidArgumentException("Invalid return type: " . json_encode($return_type));
      Severity: Minor
      Found in internal/sanitycheck.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
    function bar() {
        // lots of complicated code
    }
}

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The function check_fields() has a Cyclomatic Complexity of 31. The configured cyclomatic complexity threshold is 10.
      Open

      function check_fields(string $function_name, array $fields, array $signatures): void
{
    $return_type = $fields[0];  // TODO: Check type
    if (!is_string($return_type)) {
        throw new InvalidArgumentException("Invalid return type: " . json_encode($return_type));
      Severity: Minor
      Found in internal/sanitycheck.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      There are no issues that match your filters.

      Category
      Status