src/Phan/Analysis/AssignmentVisitor.php

Summary

Maintainability
F
2 wks
Test Coverage

File AssignmentVisitor.php has 1400 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Phan\Analysis;
Severity: Major
Found in src/Phan/Analysis/AssignmentVisitor.php - About 3 days to fix

    Function analyzeShapedArrayAssignment has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
    Open

        private function analyzeShapedArrayAssignment(Node $node): void
        {
            // Figure out the type of elements in the list
            $fallback_element_type = null;
            /** @suppress PhanAccessMethodInternal */
    Severity: Minor
    Found in src/Phan/Analysis/AssignmentVisitor.php - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function visitVar has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
    Open

        public function visitVar(Node $node): Context
        {
            try {
                $variable_name = (new ContextNode(
                    $this->code_base,
    Severity: Minor
    Found in src/Phan/Analysis/AssignmentVisitor.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function analyzeGenericArrayAssignment has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
    Open

        private function analyzeGenericArrayAssignment(Node $node): void
        {
            // Figure out the type of elements in the list
            $right_type = $this->right_type;
            if ($right_type->isEmpty()) {
    Severity: Minor
    Found in src/Phan/Analysis/AssignmentVisitor.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function analyzePropAssignment has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

        private function analyzePropAssignment(Clazz $clazz, Property $property, Node $node): Context
        {
            if ($property->isReadOnly()) {
                $this->analyzeAssignmentToReadOnlyProperty($property, $node);
            }
    Severity: Minor
    Found in src/Phan/Analysis/AssignmentVisitor.php - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    AssignmentVisitor has 36 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class AssignmentVisitor extends AnalysisVisitor
    {
        /**
         * @var UnionType
         * The type of the element on the right side of the assignment
    Severity: Minor
    Found in src/Phan/Analysis/AssignmentVisitor.php - About 4 hrs to fix

      Method visitVar has 110 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function visitVar(Node $node): Context
          {
              try {
                  $variable_name = (new ContextNode(
                      $this->code_base,
      Severity: Major
      Found in src/Phan/Analysis/AssignmentVisitor.php - About 4 hrs to fix

        Function visitDim has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
        Open

            public function visitDim(Node $node): Context
            {
                $expr_node = $node->children['expr'];
                if (!($expr_node instanceof Node)) {
                    $this->emitIssue(
        Severity: Minor
        Found in src/Phan/Analysis/AssignmentVisitor.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function visitProp has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

            public function visitProp(Node $node): Context
            {
                // Get class list first, warn if the class list is invalid.
                try {
                    $class_list = (new ContextNode(
        Severity: Minor
        Found in src/Phan/Analysis/AssignmentVisitor.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method analyzeGenericArrayAssignment has 86 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function analyzeGenericArrayAssignment(Node $node): void
            {
                // Figure out the type of elements in the list
                $right_type = $this->right_type;
                if ($right_type->isEmpty()) {
        Severity: Major
        Found in src/Phan/Analysis/AssignmentVisitor.php - About 3 hrs to fix

          Method visitProp has 84 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function visitProp(Node $node): Context
              {
                  // Get class list first, warn if the class list is invalid.
                  try {
                      $class_list = (new ContextNode(
          Severity: Major
          Found in src/Phan/Analysis/AssignmentVisitor.php - About 3 hrs to fix

            The class AssignmentVisitor has an overall complexity of 293 which is very high. The configured complexity threshold is 50.
            Open

            class AssignmentVisitor extends AnalysisVisitor
            {
                /**
                 * @var UnionType
                 * The type of the element on the right side of the assignment

            The class AssignmentVisitor has 32 non-getter- and setter-methods. Consider refactoring AssignmentVisitor to keep number of methods under 25.
            Open

            class AssignmentVisitor extends AnalysisVisitor
            {
                /**
                 * @var UnionType
                 * The type of the element on the right side of the assignment

            TooManyMethods

            Since: 0.1

            A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

            By default it ignores methods starting with 'get' or 'set'.

            The default was changed from 10 to 25 in PHPMD 2.3.

            Example

            Source https://phpmd.org/rules/codesize.html#toomanymethods

            The class AssignmentVisitor has 14 public methods. Consider refactoring AssignmentVisitor to keep number of public methods under 10.
            Open

            class AssignmentVisitor extends AnalysisVisitor
            {
                /**
                 * @var UnionType
                 * The type of the element on the right side of the assignment

            TooManyPublicMethods

            Since: 0.1

            A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

            By default it ignores methods starting with 'get' or 'set'.

            Example

            Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

            Method analyzeShapedArrayAssignment has 79 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function analyzeShapedArrayAssignment(Node $node): void
                {
                    // Figure out the type of elements in the list
                    $fallback_element_type = null;
                    /** @suppress PhanAccessMethodInternal */
            Severity: Major
            Found in src/Phan/Analysis/AssignmentVisitor.php - About 3 hrs to fix

              Method visitDim has 78 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function visitDim(Node $node): Context
                  {
                      $expr_node = $node->children['expr'];
                      if (!($expr_node instanceof Node)) {
                          $this->emitIssue(
              Severity: Major
              Found in src/Phan/Analysis/AssignmentVisitor.php - About 3 hrs to fix

                Function computeTypeSetOfMergedArrayShapeTypes has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                Open

                    private static function computeTypeSetOfMergedArrayShapeTypes(array $old_type_set, array $new_type_set, int $dim_depth, bool $is_real): array
                    {
                        if ($is_real) {
                            if (!$old_type_set || !$new_type_set) {
                                return [];
                Severity: Minor
                Found in src/Phan/Analysis/AssignmentVisitor.php - About 3 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method analyzePropAssignment has 76 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function analyzePropAssignment(Clazz $clazz, Property $property, Node $node): Context
                    {
                        if ($property->isReadOnly()) {
                            $this->analyzeAssignmentToReadOnlyProperty($property, $node);
                        }
                Severity: Major
                Found in src/Phan/Analysis/AssignmentVisitor.php - About 3 hrs to fix

                  Function typeCheckDimAssignment has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function typeCheckDimAssignment(UnionType $assign_type, Node $node): UnionType
                      {
                          static $int_or_string_type = null;
                          static $string_array_type = null;
                          static $simple_xml_element_type = null;
                  Severity: Minor
                  Found in src/Phan/Analysis/AssignmentVisitor.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method typeCheckDimAssignment has 62 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function typeCheckDimAssignment(UnionType $assign_type, Node $node): UnionType
                      {
                          static $int_or_string_type = null;
                          static $string_array_type = null;
                          static $simple_xml_element_type = null;
                  Severity: Major
                  Found in src/Phan/Analysis/AssignmentVisitor.php - About 2 hrs to fix

                    Function addTypesToProperty has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private function addTypesToProperty(Property $property, Node $node): void
                        {
                            if ($property->getRealUnionType()->isEmpty() && $property->getPHPDocUnionType()->isEmpty()) {
                                $property->setUnionType(
                                    $this->right_type
                    Severity: Minor
                    Found in src/Phan/Analysis/AssignmentVisitor.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method visitStaticProp has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function visitStaticProp(Node $node): Context
                        {
                            $property_name = $node->children['prop'];
                    
                            // Things like self::${$x}
                    Severity: Minor
                    Found in src/Phan/Analysis/AssignmentVisitor.php - About 2 hrs to fix

                      Method computeTypeSetOfMergedArrayShapeTypes has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private static function computeTypeSetOfMergedArrayShapeTypes(array $old_type_set, array $new_type_set, int $dim_depth, bool $is_real): array
                          {
                              if ($is_real) {
                                  if (!$old_type_set || !$new_type_set) {
                                      return [];
                      Severity: Minor
                      Found in src/Phan/Analysis/AssignmentVisitor.php - About 2 hrs to fix

                        Function addTypesToPropertyStandalone has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public static function addTypesToPropertyStandalone(
                                CodeBase $code_base,
                                Context $context,
                                Property $property,
                                UnionType $new_types
                        Severity: Minor
                        Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method normalizeListTypesInDimAssignment has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            private static function normalizeListTypesInDimAssignment(UnionType $assign_type, UnionType $right_type): UnionType
                            {
                                // Offsets of $can_cast:
                                // 0. lazily computed: True if list types should be kept as-is.
                                // 1. lazily computed: Should this cast from a regular array to an associative array?
                        Severity: Minor
                        Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                          Method analyzeValueNodeOfShapedArray has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private function analyzeValueNodeOfShapedArray(
                                  UnionType $element_type,
                                  $value_node
                              ): void {
                                  if (!$value_node instanceof Node) {
                          Severity: Minor
                          Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                            Method addTypesToProperty has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                private function addTypesToProperty(Property $property, Node $node): void
                                {
                                    if ($property->getRealUnionType()->isEmpty() && $property->getPHPDocUnionType()->isEmpty()) {
                                        $property->setUnionType(
                                            $this->right_type
                            Severity: Minor
                            Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                              Method analyzeSetUnionTypePassByRef has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  private static function analyzeSetUnionTypePassByRef(
                                      CodeBase $code_base,
                                      Context $context,
                                      PassByReferenceVariable $reference_element,
                                      UnionType $new_type,
                              Severity: Minor
                              Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                Method emitTypeMismatchPropertyIssue has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    private function emitTypeMismatchPropertyIssue(
                                        Node $node,
                                        Property $property,
                                        UnionType $resolved_right_type,
                                        UnionType $warn_type,
                                Severity: Minor
                                Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                  Function checkAssignmentToFunctionResult has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      private function checkAssignmentToFunctionResult(Node $node, iterable $function_list_generator): void
                                      {
                                          try {
                                              foreach ($function_list_generator as $function) {
                                                  if ($function->returnsRef()) {
                                  Severity: Minor
                                  Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function analyzeSetUnionTypePassByRef has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      private static function analyzeSetUnionTypePassByRef(
                                          CodeBase $code_base,
                                          Context $context,
                                          PassByReferenceVariable $reference_element,
                                          UnionType $new_type,
                                  Severity: Minor
                                  Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Function normalizeListTypesInDimAssignment has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      private static function normalizeListTypesInDimAssignment(UnionType $assign_type, UnionType $right_type): UnionType
                                      {
                                          // Offsets of $can_cast:
                                          // 0. lazily computed: True if list types should be kept as-is.
                                          // 1. lazily computed: Should this cast from a regular array to an associative array?
                                  Severity: Minor
                                  Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Method analyzePropertyAssignmentStrict has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      private function analyzePropertyAssignmentStrict(Property $property, UnionType $assignment_type, Node $node): void
                                      {
                                          $type_set = $assignment_type->getTypeSet();
                                          if (\count($type_set) < 2) {
                                              throw new AssertionError('Expected to have at least two types when checking if types match in strict mode');
                                  Severity: Minor
                                  Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                    Method addTypesToPropertyStandalone has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        public static function addTypesToPropertyStandalone(
                                            CodeBase $code_base,
                                            Context $context,
                                            Property $property,
                                            UnionType $new_types
                                    Severity: Minor
                                    Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                      Function visitStaticProp has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          public function visitStaticProp(Node $node): Context
                                          {
                                              $property_name = $node->children['prop'];
                                      
                                              // Things like self::${$x}
                                      Severity: Minor
                                      Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Function analyzePropertyAssignmentStrict has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          private function analyzePropertyAssignmentStrict(Property $property, UnionType $assignment_type, Node $node): void
                                          {
                                              $type_set = $assignment_type->getTypeSet();
                                              if (\count($type_set) < 2) {
                                                  throw new AssertionError('Expected to have at least two types when checking if types match in strict mode');
                                      Severity: Minor
                                      Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Function analyzeValueNodeOfShapedArray has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          private function analyzeValueNodeOfShapedArray(
                                              UnionType $element_type,
                                              $value_node
                                          ): void {
                                              if (!$value_node instanceof Node) {
                                      Severity: Minor
                                      Found in src/Phan/Analysis/AssignmentVisitor.php - About 1 hr to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Function handleThisPropertyAssignmentInLocalScopeByName has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          private function handleThisPropertyAssignmentInLocalScopeByName(Node $node, string $prop_name): void
                                          {
                                              if ($this->dim_depth === 0) {
                                                  $new_type = $this->right_type;
                                              } else {
                                      Severity: Minor
                                      Found in src/Phan/Analysis/AssignmentVisitor.php - About 55 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                              CodeBase $code_base,
                                              Context $context,
                                              Node $assignment_node,
                                              UnionType $right_type,
                                              int $dim_depth = 0,
                                      Severity: Minor
                                      Found in src/Phan/Analysis/AssignmentVisitor.php - About 45 mins to fix

                                        Method analyzeSetUnionTypePassByRef has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                                CodeBase $code_base,
                                                Context $context,
                                                PassByReferenceVariable $reference_element,
                                                UnionType $new_type,
                                                $node
                                        Severity: Minor
                                        Found in src/Phan/Analysis/AssignmentVisitor.php - About 35 mins to fix

                                          Method emitTypeMismatchPropertyIssue has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                          Open

                                                  Node $node,
                                                  Property $property,
                                                  UnionType $resolved_right_type,
                                                  UnionType $warn_type,
                                                  UnionType $property_union_type
                                          Severity: Minor
                                          Found in src/Phan/Analysis/AssignmentVisitor.php - About 35 mins to fix

                                            Method analyzeSetUnionTypeInContext has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                            Open

                                                    CodeBase $code_base,
                                                    Context $context,
                                                    TypedElementInterface $element,
                                                    UnionType $element_type,
                                                    $node
                                            Severity: Minor
                                            Found in src/Phan/Analysis/AssignmentVisitor.php - About 35 mins to fix

                                              Function visitMethodCall has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                              Open

                                                  public function visitMethodCall(Node $node): Context
                                                  {
                                                      if ($this->dim_depth >= 2) {
                                                          return $this->context;
                                                      }
                                              Severity: Minor
                                              Found in src/Phan/Analysis/AssignmentVisitor.php - About 35 mins to fix

                                              Cognitive Complexity

                                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                              A method's cognitive complexity is based on a few simple rules:

                                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                              • Code is considered more complex for each "break in the linear flow of the code"
                                              • Code is considered more complex when "flow breaking structures are nested"

                                              Further reading

                                              Function analyzeAssignmentToReadOnlyProperty has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                              Open

                                                  private function analyzeAssignmentToReadOnlyProperty(Property $property, Node $node): void
                                                  {
                                                      $is_from_phpdoc = $property->isFromPHPDoc();
                                                      $context = $property->getContext();
                                                      if (!$is_from_phpdoc && $this->context->isInFunctionLikeScope()) {
                                              Severity: Minor
                                              Found in src/Phan/Analysis/AssignmentVisitor.php - About 35 mins to fix

                                              Cognitive Complexity

                                              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                              A method's cognitive complexity is based on a few simple rules:

                                              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                              • Code is considered more complex for each "break in the linear flow of the code"
                                              • Code is considered more complex when "flow breaking structures are nested"

                                              Further reading

                                              Avoid too many return statements within this method.
                                              Open

                                                      return $this->context;
                                              Severity: Major
                                              Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                                return $this->context;
                                                Severity: Major
                                                Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                                              return true;
                                                  Severity: Major
                                                  Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                return $right_type;
                                                    Severity: Major
                                                    Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                              return $this->context;
                                                      Severity: Major
                                                      Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                return $this->context;
                                                        Severity: Major
                                                        Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                  return $right_type;
                                                          Severity: Major
                                                          Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                            Avoid too many return statements within this method.
                                                            Open

                                                                            return $this->context;
                                                            Severity: Major
                                                            Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                              Avoid too many return statements within this method.
                                                              Open

                                                                                  return $this->context;
                                                              Severity: Major
                                                              Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                                Avoid too many return statements within this method.
                                                                Open

                                                                                            return true;
                                                                Severity: Major
                                                                Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                                  Avoid too many return statements within this method.
                                                                  Open

                                                                                          return false;
                                                                  Severity: Major
                                                                  Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                                    Avoid too many return statements within this method.
                                                                    Open

                                                                                                return false;
                                                                    Severity: Major
                                                                    Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                                      Avoid too many return statements within this method.
                                                                      Open

                                                                                  return $type_set;
                                                                      Severity: Major
                                                                      Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                                        Avoid too many return statements within this method.
                                                                        Open

                                                                                return UnionType::of($new_type_set, $new_real_type_set);
                                                                        Severity: Major
                                                                        Found in src/Phan/Analysis/AssignmentVisitor.php - About 30 mins to fix

                                                                          Function checkMismatchArrayDestructuringKey has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                                                          Open

                                                                              private function checkMismatchArrayDestructuringKey($expect_int_keys_lineno, $expect_string_keys_lineno): void
                                                                              {
                                                                                  if ($expect_int_keys_lineno !== false || $expect_string_keys_lineno !== false) {
                                                                                      $right_hand_key_type = GenericArrayType::keyTypeFromUnionTypeKeys($this->right_type);
                                                                                      if ($expect_int_keys_lineno !== false && ($right_hand_key_type & GenericArrayType::KEY_INT) === 0) {
                                                                          Severity: Minor
                                                                          Found in src/Phan/Analysis/AssignmentVisitor.php - About 25 mins to fix

                                                                          Cognitive Complexity

                                                                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                                          A method's cognitive complexity is based on a few simple rules:

                                                                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                                          • Code is considered more complex for each "break in the linear flow of the code"
                                                                          • Code is considered more complex when "flow breaking structures are nested"

                                                                          Further reading

                                                                          The method analyzeShapedArrayAssignment() has 101 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                                          Open

                                                                              private function analyzeShapedArrayAssignment(Node $node): void
                                                                              {
                                                                                  // Figure out the type of elements in the list
                                                                                  $fallback_element_type = null;
                                                                                  /** @suppress PhanAccessMethodInternal */

                                                                          The method analyzeGenericArrayAssignment() has 116 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                                          Open

                                                                              private function analyzeGenericArrayAssignment(Node $node): void
                                                                              {
                                                                                  // Figure out the type of elements in the list
                                                                                  $right_type = $this->right_type;
                                                                                  if ($right_type->isEmpty()) {

                                                                          The method visitDim() has an NPath complexity of 432. The configured NPath complexity threshold is 200.
                                                                          Open

                                                                              public function visitDim(Node $node): Context
                                                                              {
                                                                                  $expr_node = $node->children['expr'];
                                                                                  if (!($expr_node instanceof Node)) {
                                                                                      $this->emitIssue(

                                                                          NPathComplexity

                                                                          Since: 0.1

                                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                          Example

                                                                          class Foo {
                                                                              function bar() {
                                                                                  // lots of complicated code
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                          The method visitProp() has 108 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                                          Open

                                                                              public function visitProp(Node $node): Context
                                                                              {
                                                                                  // Get class list first, warn if the class list is invalid.
                                                                                  try {
                                                                                      $class_list = (new ContextNode(

                                                                          The method addTypesToProperty() has an NPath complexity of 444. The configured NPath complexity threshold is 200.
                                                                          Open

                                                                              private function addTypesToProperty(Property $property, Node $node): void
                                                                              {
                                                                                  if ($property->getRealUnionType()->isEmpty() && $property->getPHPDocUnionType()->isEmpty()) {
                                                                                      $property->setUnionType(
                                                                                          $this->right_type

                                                                          NPathComplexity

                                                                          Since: 0.1

                                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                          Example

                                                                          class Foo {
                                                                              function bar() {
                                                                                  // lots of complicated code
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                          The method addTypesToPropertyStandalone() has an NPath complexity of 222. The configured NPath complexity threshold is 200.
                                                                          Open

                                                                              public static function addTypesToPropertyStandalone(
                                                                                  CodeBase $code_base,
                                                                                  Context $context,
                                                                                  Property $property,
                                                                                  UnionType $new_types

                                                                          NPathComplexity

                                                                          Since: 0.1

                                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                          Example

                                                                          class Foo {
                                                                              function bar() {
                                                                                  // lots of complicated code
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                          The method visitVar() has an NPath complexity of 5472. The configured NPath complexity threshold is 200.
                                                                          Open

                                                                              public function visitVar(Node $node): Context
                                                                              {
                                                                                  try {
                                                                                      $variable_name = (new ContextNode(
                                                                                          $this->code_base,

                                                                          NPathComplexity

                                                                          Since: 0.1

                                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                          Example

                                                                          class Foo {
                                                                              function bar() {
                                                                                  // lots of complicated code
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                          The method computeTypeSetOfMergedArrayShapeTypes() has an NPath complexity of 576. The configured NPath complexity threshold is 200.
                                                                          Open

                                                                              private static function computeTypeSetOfMergedArrayShapeTypes(array $old_type_set, array $new_type_set, int $dim_depth, bool $is_real): array
                                                                              {
                                                                                  if ($is_real) {
                                                                                      if (!$old_type_set || !$new_type_set) {
                                                                                          return [];

                                                                          NPathComplexity

                                                                          Since: 0.1

                                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                          Example

                                                                          class Foo {
                                                                              function bar() {
                                                                                  // lots of complicated code
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                          The method visitProp() has an NPath complexity of 5824. The configured NPath complexity threshold is 200.
                                                                          Open

                                                                              public function visitProp(Node $node): Context
                                                                              {
                                                                                  // Get class list first, warn if the class list is invalid.
                                                                                  try {
                                                                                      $class_list = (new ContextNode(

                                                                          NPathComplexity

                                                                          Since: 0.1

                                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                          Example

                                                                          class Foo {
                                                                              function bar() {
                                                                                  // lots of complicated code
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                          The method analyzePropAssignment() has 103 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                                          Open

                                                                              private function analyzePropAssignment(Clazz $clazz, Property $property, Node $node): Context
                                                                              {
                                                                                  if ($property->isReadOnly()) {
                                                                                      $this->analyzeAssignmentToReadOnlyProperty($property, $node);
                                                                                  }

                                                                          The method visitVar() has 144 lines of code. Current threshold is set to 100. Avoid really long methods.
                                                                          Open

                                                                              public function visitVar(Node $node): Context
                                                                              {
                                                                                  try {
                                                                                      $variable_name = (new ContextNode(
                                                                                          $this->code_base,

                                                                          The method typeCheckDimAssignment() has an NPath complexity of 420. The configured NPath complexity threshold is 200.
                                                                          Open

                                                                              public function typeCheckDimAssignment(UnionType $assign_type, Node $node): UnionType
                                                                              {
                                                                                  static $int_or_string_type = null;
                                                                                  static $string_array_type = null;
                                                                                  static $simple_xml_element_type = null;

                                                                          NPathComplexity

                                                                          Since: 0.1

                                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                          Example

                                                                          class Foo {
                                                                              function bar() {
                                                                                  // lots of complicated code
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                          The class AssignmentVisitor has 1924 lines of code. Current threshold is 1000. Avoid really long classes.
                                                                          Open

                                                                          class AssignmentVisitor extends AnalysisVisitor
                                                                          {
                                                                              /**
                                                                               * @var UnionType
                                                                               * The type of the element on the right side of the assignment

                                                                          The method analyzeShapedArrayAssignment() has an NPath complexity of 626. The configured NPath complexity threshold is 200.
                                                                          Open

                                                                              private function analyzeShapedArrayAssignment(Node $node): void
                                                                              {
                                                                                  // Figure out the type of elements in the list
                                                                                  $fallback_element_type = null;
                                                                                  /** @suppress PhanAccessMethodInternal */

                                                                          NPathComplexity

                                                                          Since: 0.1

                                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                          Example

                                                                          class Foo {
                                                                              function bar() {
                                                                                  // lots of complicated code
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                          The method analyzeGenericArrayAssignment() has an NPath complexity of 363. The configured NPath complexity threshold is 200.
                                                                          Open

                                                                              private function analyzeGenericArrayAssignment(Node $node): void
                                                                              {
                                                                                  // Figure out the type of elements in the list
                                                                                  $right_type = $this->right_type;
                                                                                  if ($right_type->isEmpty()) {

                                                                          NPathComplexity

                                                                          Since: 0.1

                                                                          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                                                                          Example

                                                                          class Foo {
                                                                              function bar() {
                                                                                  // lots of complicated code
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#npathcomplexity

                                                                          The method addTypesToProperty() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              private function addTypesToProperty(Property $property, Node $node): void
                                                                              {
                                                                                  if ($property->getRealUnionType()->isEmpty() && $property->getPHPDocUnionType()->isEmpty()) {
                                                                                      $property->setUnionType(
                                                                                          $this->right_type

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method normalizeListTypesInDimAssignment() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              private static function normalizeListTypesInDimAssignment(UnionType $assign_type, UnionType $right_type): UnionType
                                                                              {
                                                                                  // Offsets of $can_cast:
                                                                                  // 0. lazily computed: True if list types should be kept as-is.
                                                                                  // 1. lazily computed: Should this cast from a regular array to an associative array?

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method visitProp() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              public function visitProp(Node $node): Context
                                                                              {
                                                                                  // Get class list first, warn if the class list is invalid.
                                                                                  try {
                                                                                      $class_list = (new ContextNode(

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method typeCheckDimAssignment() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              public function typeCheckDimAssignment(UnionType $assign_type, Node $node): UnionType
                                                                              {
                                                                                  static $int_or_string_type = null;
                                                                                  static $string_array_type = null;
                                                                                  static $simple_xml_element_type = null;

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method analyzePropAssignment() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              private function analyzePropAssignment(Clazz $clazz, Property $property, Node $node): Context
                                                                              {
                                                                                  if ($property->isReadOnly()) {
                                                                                      $this->analyzeAssignmentToReadOnlyProperty($property, $node);
                                                                                  }

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method analyzeShapedArrayAssignment() has a Cyclomatic Complexity of 17. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              private function analyzeShapedArrayAssignment(Node $node): void
                                                                              {
                                                                                  // Figure out the type of elements in the list
                                                                                  $fallback_element_type = null;
                                                                                  /** @suppress PhanAccessMethodInternal */

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method addTypesToPropertyStandalone() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              public static function addTypesToPropertyStandalone(
                                                                                  CodeBase $code_base,
                                                                                  Context $context,
                                                                                  Property $property,
                                                                                  UnionType $new_types

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method analyzeSetUnionTypePassByRef() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              private static function analyzeSetUnionTypePassByRef(
                                                                                  CodeBase $code_base,
                                                                                  Context $context,
                                                                                  PassByReferenceVariable $reference_element,
                                                                                  UnionType $new_type,

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method analyzeGenericArrayAssignment() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              private function analyzeGenericArrayAssignment(Node $node): void
                                                                              {
                                                                                  // Figure out the type of elements in the list
                                                                                  $right_type = $this->right_type;
                                                                                  if ($right_type->isEmpty()) {

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method visitVar() has a Cyclomatic Complexity of 21. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              public function visitVar(Node $node): Context
                                                                              {
                                                                                  try {
                                                                                      $variable_name = (new ContextNode(
                                                                                          $this->code_base,

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method computeTypeSetOfMergedArrayShapeTypes() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              private static function computeTypeSetOfMergedArrayShapeTypes(array $old_type_set, array $new_type_set, int $dim_depth, bool $is_real): array
                                                                              {
                                                                                  if ($is_real) {
                                                                                      if (!$old_type_set || !$new_type_set) {
                                                                                          return [];

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method analyzePropertyAssignmentStrict() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              private function analyzePropertyAssignmentStrict(Property $property, UnionType $assignment_type, Node $node): void
                                                                              {
                                                                                  $type_set = $assignment_type->getTypeSet();
                                                                                  if (\count($type_set) < 2) {
                                                                                      throw new AssertionError('Expected to have at least two types when checking if types match in strict mode');

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The method visitDim() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
                                                                          Open

                                                                              public function visitDim(Node $node): Context
                                                                              {
                                                                                  $expr_node = $node->children['expr'];
                                                                                  if (!($expr_node instanceof Node)) {
                                                                                      $this->emitIssue(

                                                                          CyclomaticComplexity

                                                                          Since: 0.1

                                                                          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                                                                          Example

                                                                          // Cyclomatic Complexity = 11
                                                                          class Foo {
                                                                          1   public function example() {
                                                                          2       if ($a == $b) {
                                                                          3           if ($a1 == $b1) {
                                                                                          fiddle();
                                                                          4           } elseif ($a2 == $b2) {
                                                                                          fiddle();
                                                                                      } else {
                                                                                          fiddle();
                                                                                      }
                                                                          5       } elseif ($c == $d) {
                                                                          6           while ($c == $d) {
                                                                                          fiddle();
                                                                                      }
                                                                          7        } elseif ($e == $f) {
                                                                          8           for ($n = 0; $n < $h; $n++) {
                                                                                          fiddle();
                                                                                      }
                                                                                  } else {
                                                                                      switch ($z) {
                                                                          9               case 1:
                                                                                              fiddle();
                                                                                              break;
                                                                          10              case 2:
                                                                                              fiddle();
                                                                                              break;
                                                                          11              case 3:
                                                                                              fiddle();
                                                                                              break;
                                                                                          default:
                                                                                              fiddle();
                                                                                              break;
                                                                                      }
                                                                                  }
                                                                              }
                                                                          }

                                                                          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                                                                          The class AssignmentVisitor has a coupling between objects value of 40. Consider to reduce the number of dependencies under 13.
                                                                          Open

                                                                          class AssignmentVisitor extends AnalysisVisitor
                                                                          {
                                                                              /**
                                                                               * @var UnionType
                                                                               * The type of the element on the right side of the assignment

                                                                          CouplingBetweenObjects

                                                                          Since: 1.1.0

                                                                          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

                                                                          Example

                                                                          class Foo {
                                                                              /**
                                                                               * @var \foo\bar\X
                                                                               */
                                                                              private $x = null;
                                                                          
                                                                              /**
                                                                               * @var \foo\bar\Y
                                                                               */
                                                                              private $y = null;
                                                                          
                                                                              /**
                                                                               * @var \foo\bar\Z
                                                                               */
                                                                              private $z = null;
                                                                          
                                                                              public function setFoo(\Foo $foo) {}
                                                                              public function setBar(\Bar $bar) {}
                                                                              public function setBaz(\Baz $baz) {}
                                                                          
                                                                              /**
                                                                               * @return \SplObjectStorage
                                                                               * @throws \OutOfRangeException
                                                                               * @throws \InvalidArgumentException
                                                                               * @throws \ErrorException
                                                                               */
                                                                              public function process(\Iterator $it) {}
                                                                          
                                                                              // ...
                                                                          }

                                                                          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

                                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                                          Open

                                                                                              $result = ($can_cast[1] = ($can_cast[1] ?? $assign_type->hasTypeMatchingCallback(static function (Type $other_type): bool {
                                                                                                  if (!$other_type instanceof ArrayType) {
                                                                                                      return false;
                                                                                                  }
                                                                                                  if ($other_type instanceof AssociativeArrayType) {
                                                                          Severity: Major
                                                                          Found in src/Phan/Analysis/AssignmentVisitor.php and 1 other location - About 1 hr to fix
                                                                          src/Phan/Analysis/AssignmentVisitor.php on lines 1908..1920

                                                                          Duplicated Code

                                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                          Tuning

                                                                          This issue has a mass of 103.

                                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                          Refactorings

                                                                          Further Reading

                                                                          Similar blocks of code found in 2 locations. Consider refactoring.
                                                                          Open

                                                                                              $result = ($can_cast[0] = ($can_cast[0] ?? $assign_type->hasTypeMatchingCallback(static function (Type $other_type): bool {
                                                                                                  if (!$other_type instanceof ArrayType) {
                                                                                                      return false;
                                                                                                  }
                                                                                                  if ($other_type instanceof ListType) {
                                                                          Severity: Major
                                                                          Found in src/Phan/Analysis/AssignmentVisitor.php and 1 other location - About 1 hr to fix
                                                                          src/Phan/Analysis/AssignmentVisitor.php on lines 1926..1938

                                                                          Duplicated Code

                                                                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                                          Tuning

                                                                          This issue has a mass of 103.

                                                                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                                          Refactorings

                                                                          Further Reading

                                                                          There are no issues that match your filters.

                                                                          Category
                                                                          Status