# etsy/phan

src/Phan/Analysis/ConditionVisitor.php

### Summary

F
1 wk

#### File ConditionVisitor.php has 801 lines of code (exceeds 250 allowed). Consider refactoring. Open

<?php

declare(strict_types=1);

namespace Phan\Analysis;
Found in src/Phan/Analysis/ConditionVisitor.php - About 1 day to fix

#### Function checkComplexIsset has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring. Open

    private function checkComplexIsset(Node $node): Context { // Loop to support getting the var name in is_array($x['field'][0])
$union_type_string Found in src/Phan/Analysis/ConditionVisitor.php - About 4 hrs to fix #### Function calculateNarrowedUnionType has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open  private static function calculateNarrowedUnionType(CodeBase$code_base, Context $context, UnionType$old_type, UnionType $asserted_object_type): UnionType {$new_type_set = [];
foreach ($old_type->getTypeSet() as$type) {
if ($type instanceof MixedType) { Found in src/Phan/Analysis/ConditionVisitor.php - About 3 hrs to fix # Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. ### A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" ### Further reading #### ConditionVisitor has 30 functions (exceeds 20 allowed). Consider refactoring. Open class ConditionVisitor extends KindVisitorImplementation implements ConditionVisitorInterface { use ConditionVisitorUtil; /** @internal */ Found in src/Phan/Analysis/ConditionVisitor.php - About 3 hrs to fix #### The class ConditionVisitor has 27 non-getter- and setter-methods. Consider refactoring ConditionVisitor to keep number of methods under 25. Open class ConditionVisitor extends KindVisitorImplementation implements ConditionVisitorInterface { use ConditionVisitorUtil; /** @internal */ ## TooManyMethods ### Since: 0.1 A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects. By default it ignores methods starting with 'get' or 'set'. The default was changed from 10 to 25 in PHPMD 2.3. ## Example ### Source https://phpmd.org/rules/codesize.html#toomanymethods #### The class ConditionVisitor has an overall complexity of 165 which is very high. The configured complexity threshold is 50. Open class ConditionVisitor extends KindVisitorImplementation implements ConditionVisitorInterface { use ConditionVisitorUtil; /** @internal */ #### The class ConditionVisitor has 16 public methods. Consider refactoring ConditionVisitor to keep number of public methods under 10. Open class ConditionVisitor extends KindVisitorImplementation implements ConditionVisitorInterface { use ConditionVisitorUtil; /** @internal */ ## TooManyPublicMethods ### Since: 0.1 A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects. By default it ignores methods starting with 'get' or 'set'. ## Example ### Source https://phpmd.org/rules/codesize.html#toomanypublicmethods #### Function visitCall has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open  public function visitCall(Node$node): Context
{
// Analyze the call to the node, in case it modifies any variables (e.g. count($x = new_value()), if (preg_match(...,$matches), etc.
// TODO: Limit this to nodes which actually contain variables or properties?
// TODO: Only call this if the caller is also a ConditionVisitor, since BlockAnalysisVisitor would call this for ternaries and if statements already.
Found in src/Phan/Analysis/ConditionVisitor.php - About 3 hrs to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Method checkComplexIsset has 76 lines of code (exceeds 25 allowed). Consider refactoring. Open

    private function checkComplexIsset(Node $node): Context { // Loop to support getting the var name in is_array($x['field'][0])
$has_prop_access = false;$context = $this->context; Found in src/Phan/Analysis/ConditionVisitor.php - About 3 hrs to fix #### Method visitCall has 59 lines of code (exceeds 25 allowed). Consider refactoring. Open  public function visitCall(Node$node): Context
{
// Analyze the call to the node, in case it modifies any variables (e.g. count($x = new_value()), if (preg_match(...,$matches), etc.
// TODO: Limit this to nodes which actually contain variables or properties?
// TODO: Only call this if the caller is also a ConditionVisitor, since BlockAnalysisVisitor would call this for ternaries and if statements already.
Found in src/Phan/Analysis/ConditionVisitor.php - About 2 hrs to fix

#### Method calculateNarrowedUnionType has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open

    private static function calculateNarrowedUnionType(CodeBase $code_base, Context$context, UnionType $old_type, UnionType$asserted_object_type): UnionType
{
$new_type_set = []; foreach ($old_type->getTypeSet() as $type) { if ($type instanceof MixedType) {
Found in src/Phan/Analysis/ConditionVisitor.php - About 1 hr to fix

    private function withSetVariable(string $var_name, Node$var_node, Node $ancestor_node): Context {$context = $this->context;$is_object = $var_node->kind === ast\AST_PROP;  Found in src/Phan/Analysis/ConditionVisitor.php - About 1 hr to fix #### Method visitInstanceof has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open  public function visitInstanceof(Node$node): Context
{
//$this->checkVariablesDefined($node);
// Only look at things of the form
// $variable instanceof ClassName Found in src/Phan/Analysis/ConditionVisitor.php - About 1 hr to fix #### Function withSetVariable has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open  private function withSetVariable(string$var_name, Node $var_node, Node$ancestor_node): Context
{
$context =$this->context;
$is_object =$var_node->kind === ast\AST_PROP;


Found in src/Phan/Analysis/ConditionVisitor.php - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function visitUnaryOp has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open

    public function visitUnaryOp(Node $node): Context {$expr_node = $node->children['expr'];$flags = $node->flags; if ($flags !== flags\UNARY_BOOL_NOT) {
Found in src/Phan/Analysis/ConditionVisitor.php - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function initTypeModifyingClosuresForVisitCall has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open

    private static function initTypeModifyingClosuresForVisitCall(): array
{
$make_direct_assertion_callback = static function (string$union_type_string): Closure {
$asserted_union_type = UnionType::fromFullyQualifiedRealString($union_type_string
Found in src/Phan/Analysis/ConditionVisitor.php - About 1 hr to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Method visitBinaryOp has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open

    public function visitBinaryOp(Node $node): Context {$flags = $node->flags; switch ($flags) {
case flags\BINARY_BOOL_AND:
Found in src/Phan/Analysis/ConditionVisitor.php - About 1 hr to fix

#### Function visitExprList has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open

    public function visitExprList(Node $node): Context {$children = $node->children;$count = \count($children); if ($count > 1) {
Found in src/Phan/Analysis/ConditionVisitor.php - About 55 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### Function analyzeShortCircuitingOr has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open

    private function analyzeShortCircuitingOr($left,$right): Context
{
// Aside: If left/right is not a node, left/right is a literal such as a number/string, and is either always truthy or always falsey.
// Inside of this conditional may be dead or redundant code.
if (!($left instanceof Node)) { Found in src/Phan/Analysis/ConditionVisitor.php - About 45 mins to fix # Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. ### A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" ### Further reading #### Function withSetArrayShapeTypes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open  private function withSetArrayShapeTypes(UnionType$union_type, $dim_node, Context$context, bool $non_nullable): UnionType {$dim_value = $dim_node instanceof Node ? (new ContextNode($this->code_base, $context,$dim_node))->getEquivalentPHPScalarValue() : $dim_node; // TODO: detect and warn about null if (!\is_scalar($dim_value)) {
Found in src/Phan/Analysis/ConditionVisitor.php - About 45 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

                return $context; Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return$this->__invoke($left); Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return$this->withSetVariable($var_name,$parent_node, $node); Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return$context;
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

        return $union_type; Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return$context;
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

#### Avoid too many return statements within this method. Open

            return ArrayType::combineArrayShapeTypesWithField(
$union_type,$dim_value,
$dim_union_type->nonNullableClone()->withIsPossiblyUndefined(false) ); Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return UnionType::of($new_type_set, $old_type->getRealTypeSet()); Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return (new ContextMergeVisitor($context, [$left_true_context,$right_true_context]))->combineChildContextList();
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

        return $context; Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return$context->withScopeVariable(new Variable(
$context->withLineNumberStart($node->lineno ?? 0),
$var_name,$new_type,  // can be array or (unlikely) ArrayAccess
0
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

#### Avoid too many return statements within this method. Open

            return UnionType::of($new_type_set,$old_type->getRealTypeSet());
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

#### Avoid too many return statements within this method. Open

                return $this->analyzeAndUpdateToBeCompared($node->children['left'], $node->children['right'],$flags);
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

                return $this->context; Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return UnionType::of($new_type_set, $new_real_type_set ?:$asserted_object_type->getRealTypeSet());
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

                return $this->analyzeAndUpdateToBeNotIdentical($node->children['left'], $node->children['right']); Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return$this->context;
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

        return $this->removeNullFromVariable($var_node, $context, true); Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return$this->analyzeAndUpdateToBeNotEqual($node->children['left'],$node->children['right']);
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

                return $this->context; Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return UnionType::of($new_type_set, $old_type->getRealTypeSet()); Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix #### Avoid too many return statements within this method. Open  return$this->modifyComplexExpression($first_arg,$type_modification_callback, $this->context,$args);
Found in src/Phan/Analysis/ConditionVisitor.php - About 30 mins to fix

#### Function visitInstanceof has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

    public function visitInstanceof(Node $node): Context { //$this->checkVariablesDefined($node); // Only look at things of the form // $variable instanceof ClassName
Found in src/Phan/Analysis/ConditionVisitor.php - About 25 mins to fix

# Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

### A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

#### The method calculateNarrowedUnionType() has an NPath complexity of 4488. The configured NPath complexity threshold is 200. Open

    private static function calculateNarrowedUnionType(CodeBase $code_base, Context$context, UnionType $old_type, UnionType$asserted_object_type): UnionType
{
$new_type_set = []; foreach ($old_type->getTypeSet() as $type) { if ($type instanceof MixedType) {

## NPathComplexity

### Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

## Example

class Foo {
function bar() {
// lots of complicated code
}
}

### Source https://phpmd.org/rules/codesize.html#npathcomplexity

#### The method checkComplexIsset() has an NPath complexity of 2640. The configured NPath complexity threshold is 200. Open

    private function checkComplexIsset(Node $node): Context { // Loop to support getting the var name in is_array($x['field'][0])
$has_prop_access = false;$context = $this->context; ## NPathComplexity ### Since: 0.1 The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity. ## Example class Foo { function bar() { // lots of complicated code } } ### Source https://phpmd.org/rules/codesize.html#npathcomplexity #### The class ConditionVisitor has 1190 lines of code. Current threshold is 1000. Avoid really long classes. Open class ConditionVisitor extends KindVisitorImplementation implements ConditionVisitorInterface { use ConditionVisitorUtil; /** @internal */ #### The method visitCall() has an NPath complexity of 2400. The configured NPath complexity threshold is 200. Open  public function visitCall(Node$node): Context
{
// Analyze the call to the node, in case it modifies any variables (e.g. count($x = new_value()), if (preg_match(...,$matches), etc.
// TODO: Limit this to nodes which actually contain variables or properties?
// TODO: Only call this if the caller is also a ConditionVisitor, since BlockAnalysisVisitor would call this for ternaries and if statements already.

## NPathComplexity

### Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

## Example

class Foo {
function bar() {
// lots of complicated code
}
}

### Source https://phpmd.org/rules/codesize.html#npathcomplexity

#### The method initTypeModifyingClosuresForVisitCall() has 173 lines of code. Current threshold is set to 100. Avoid really long methods. Open

    private static function initTypeModifyingClosuresForVisitCall(): array
{
$make_direct_assertion_callback = static function (string$union_type_string): Closure {
$asserted_union_type = UnionType::fromFullyQualifiedRealString($union_type_string

    private function withSetVariable(string $var_name, Node$var_node, Node $ancestor_node): Context {$context = $this->context;$is_object = $var_node->kind === ast\AST_PROP;  ## CyclomaticComplexity ### Since: 0.1 Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity. ## Example // Cyclomatic Complexity = 11 class Foo { 1 public function example() { 2 if ($a == $b) { 3 if ($a1 == $b1) { fiddle(); 4 } elseif ($a2 == $b2) { fiddle(); } else { fiddle(); } 5 } elseif ($c == $d) { 6 while ($c == $d) { fiddle(); } 7 } elseif ($e == $f) { 8 for ($n = 0; $n <$h; $n++) { fiddle(); } } else { switch ($z) {
9               case 1:
fiddle();
break;
10              case 2:
fiddle();
break;
11              case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}

### Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

#### The method visitBinaryOp() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open

    public function visitBinaryOp(Node $node): Context {$flags = $node->flags; switch ($flags) {
case flags\BINARY_BOOL_AND:

## CyclomaticComplexity

### Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

## Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a ==$b) {
3           if ($a1 ==$b1) {
fiddle();
4           } elseif ($a2 ==$b2) {
fiddle();
} else {
fiddle();
}
5       } elseif ($c ==$d) {
6           while ($c ==$d) {
fiddle();
}
7        } elseif ($e ==$f) {
8           for ($n = 0;$n < $h;$n++) {
fiddle();
}
} else {
switch ($z) { 9 case 1: fiddle(); break; 10 case 2: fiddle(); break; 11 case 3: fiddle(); break; default: fiddle(); break; } } } } ### Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity #### The method checkComplexIsset() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10. Open  private function checkComplexIsset(Node$node): Context
{
// Loop to support getting the var name in is_array($x['field'][0])$has_prop_access = false;
$context =$this->context;

## CyclomaticComplexity

### Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

## Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a ==$b) {
3           if ($a1 ==$b1) {
fiddle();
4           } elseif ($a2 ==$b2) {
fiddle();
} else {
fiddle();
}
5       } elseif ($c ==$d) {
6           while ($c ==$d) {
fiddle();
}
7        } elseif ($e ==$f) {
8           for ($n = 0;$n < $h;$n++) {
fiddle();
}
} else {
switch ($z) { 9 case 1: fiddle(); break; 10 case 2: fiddle(); break; 11 case 3: fiddle(); break; default: fiddle(); break; } } } } ### Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity #### The method visitCall() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10. Open  public function visitCall(Node$node): Context
{
// Analyze the call to the node, in case it modifies any variables (e.g. count($x = new_value()), if (preg_match(...,$matches), etc.
// TODO: Limit this to nodes which actually contain variables or properties?
// TODO: Only call this if the caller is also a ConditionVisitor, since BlockAnalysisVisitor would call this for ternaries and if statements already.

## CyclomaticComplexity

### Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

## Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a ==$b) {
3           if ($a1 ==$b1) {
fiddle();
4           } elseif ($a2 ==$b2) {
fiddle();
} else {
fiddle();
}
5       } elseif ($c ==$d) {
6           while ($c ==$d) {
fiddle();
}
7        } elseif ($e ==$f) {
8           for ($n = 0;$n < $h;$n++) {
fiddle();
}
} else {
switch ($z) { 9 case 1: fiddle(); break; 10 case 2: fiddle(); break; 11 case 3: fiddle(); break; default: fiddle(); break; } } } } ### Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity #### The method calculateNarrowedUnionType() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10. Open  private static function calculateNarrowedUnionType(CodeBase$code_base, Context $context, UnionType$old_type, UnionType $asserted_object_type): UnionType {$new_type_set = [];
foreach ($old_type->getTypeSet() as$type) {
if ($type instanceof MixedType) { ## CyclomaticComplexity ### Since: 0.1 Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity. ## Example // Cyclomatic Complexity = 11 class Foo { 1 public function example() { 2 if ($a == $b) { 3 if ($a1 == $b1) { fiddle(); 4 } elseif ($a2 == $b2) { fiddle(); } else { fiddle(); } 5 } elseif ($c == $d) { 6 while ($c == $d) { fiddle(); } 7 } elseif ($e == $f) { 8 for ($n = 0; $n <$h; $n++) { fiddle(); } } else { switch ($z) {
9               case 1:
fiddle();
break;
10              case 2:
fiddle();
break;
11              case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}

### Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

#### The class ConditionVisitor has a coupling between objects value of 31. Consider to reduce the number of dependencies under 13. Open

class ConditionVisitor extends KindVisitorImplementation implements ConditionVisitorInterface
{
use ConditionVisitorUtil;

/** @internal */

## CouplingBetweenObjects

### Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

## Example

class Foo {
/**
* @var \foo\bar\X
*/
private $x = null; /** * @var \foo\bar\Y */ private$y = null;

/**
* @var \foo\bar\Z
*/
private $z = null; public function setFoo(\Foo$foo) {}
public function setBar(\Bar $bar) {} public function setBaz(\Baz$baz) {}

/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {} // ... } ### Source https://phpmd.org/rules/design.html#couplingbetweenobjects #### Similar blocks of code found in 2 locations. Consider refactoring. Open  public function visitProp(Node$node): Context
{
// TODO: Make this imply $expr_node is an object?$expr_node = $node->children['expr']; if (!($expr_node instanceof Node)) {
Found in src/Phan/Analysis/ConditionVisitor.php and 1 other location - About 4 hrs to fix
src/Phan/Analysis/NegatedConditionVisitor.php on lines 364..386

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 171.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

## Refactorings

#### Identical blocks of code found in 2 locations. Consider refactoring. Open

    public function visitAssign(Node $node): Context {$context = (new BlockAnalysisVisitor($this->code_base,$this->context))->visitAssign($node);$left = $node->children['var']; if (!($left instanceof Node)) {
Found in src/Phan/Analysis/ConditionVisitor.php and 1 other location - About 3 hrs to fix
src/Phan/Analysis/NegatedConditionVisitor.php on lines 1028..1044

## Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

## Tuning

This issue has a mass of 151.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

## Refactorings

#### Similar blocks of code found in 2 locations. Consider refactoring. Open

        try {
// Get the variable we're operating on
$variable =$this->getVariableFromScope($first_arg,$context);

if (\is_null($variable)) { Found in src/Phan/Analysis/ConditionVisitor.php and 1 other location - About 1 hr to fix src/Phan/Analysis/NegatedConditionVisitor.php on lines 308..331 ## Duplicated Code Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states: Every piece of knowledge must have a single, unambiguous, authoritative representation within a system. When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways). ## Tuning This issue has a mass of 112. We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines. The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison. If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language. See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml. ## Refactorings ## Further Reading #### Identical blocks of code found in 2 locations. Consider refactoring. Open  if ($flags !== flags\UNARY_BOOL_NOT) {
if (Config::getValue('redundant_condition_detection')) {
$this->checkRedundantOrImpossibleTruthyCondition($node, $this->context, null, false); } // TODO: Emit dead code issue for non-nodes Found in src/Phan/Analysis/ConditionVisitor.php and 1 other location - About 45 mins to fix src/Phan/Analysis/NegatedConditionVisitor.php on lines 245..256 ## Duplicated Code Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states: Every piece of knowledge must have a single, unambiguous, authoritative representation within a system. When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways). ## Tuning This issue has a mass of 95. We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines. The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison. If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language. See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml. ## Refactorings ## Further Reading #### Identical blocks of code found in 2 locations. Consider refactoring. Open  public function visitAssignRef(Node$node): Context
{
$context = (new BlockAnalysisVisitor($this->code_base, $this->context))->visitAssignRef($node);
$left =$node->children['var'];

        $cv = new ConditionVisitor($code_base, $context); ## ShortVariable ### Since: 0.2 Detects when a field, local, or parameter has a very short name. ## Example class Something { private$q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal$r = 20 + $this->q; // VIOLATION - Local for (int$i = 0; $i < 10;$i++) { // Not a Violation (inside FOR)
$r +=$this->q;
}
}
}

## ShortVariable

### Since: 0.2

Detects when a field, local, or parameter has a very short name.

## Example

class Something {
private $q = 15; // VIOLATION - Field public static function main( array$as ) { // VIOLATION - Formal
$r = 20 +$this->q; // VIOLATION - Local
for (int $i = 0;$i < 10; $i++) { // Not a Violation (inside FOR)$r += \$this->q;
}
}
}