Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Analysis/ConditionVisitor/EqualsCondition.php

Summary

Maintainability
B
4 hrs
Test Coverage

Avoid too many return statements within this method.
Open

        return null;
Severity: Major
Found in src/Phan/Analysis/ConditionVisitor/EqualsCondition.php - About 30 mins to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public function analyzeComplexCondition(ConditionVisitorInterface $visitor, Node $complex_node, $expr): ?Context
    {
        $code_base = $visitor->getCodeBase();
        $context = $visitor->getContext();
        $expr_type = UnionTypeVisitor::unionTypeFromNode($code_base, $context, $expr);
    Severity: Major
    Found in src/Phan/Analysis/ConditionVisitor/EqualsCondition.php and 2 other locations - About 4 hrs to fix
    src/Phan/Analysis/ConditionVisitor/NotEqualsCondition.php on lines 44..60
    src/Phan/Analysis/ConditionVisitor/NotEqualsCondition.php on lines 62..78

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 168.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status