Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Analysis/DuplicateFunctionAnalyzer.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method analyzeDuplicateFunction has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function analyzeDuplicateFunction(
        CodeBase $code_base,
        FunctionInterface $method
    ): void {
        $fqsen = $method->getFQSEN();
Severity: Major
Found in src/Phan/Analysis/DuplicateFunctionAnalyzer.php - About 2 hrs to fix

    Function analyzeDuplicateFunction has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function analyzeDuplicateFunction(
        CodeBase $code_base,
        FunctionInterface $method
    ): void {
        $fqsen = $method->getFQSEN();
    Severity: Minor
    Found in src/Phan/Analysis/DuplicateFunctionAnalyzer.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status