src/Phan/Daemon.php

Summary

Maintainability
C
1 day
Test Coverage

Method run has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function run(CodeBase $code_base, Closure $file_path_lister): ?Request
    {
        if (Config::getValue('language_server_use_pcntl_fallback')) {
            self::runWithoutPcntl($code_base, $file_path_lister);
            // Not reachable
Severity: Major
Found in src/Phan/Daemon.php - About 2 hrs to fix

    Function run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function run(CodeBase $code_base, Closure $file_path_lister): ?Request
        {
            if (Config::getValue('language_server_use_pcntl_fallback')) {
                self::runWithoutPcntl($code_base, $file_path_lister);
                // Not reachable
    Severity: Minor
    Found in src/Phan/Daemon.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method runWithoutPcntl has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function runWithoutPcntl(CodeBase $code_base, Closure $file_path_lister): void
        {
            // This is a single threaded server, it only analyzes one TCP request at a time
            $socket_server = self::createDaemonStreamSocketServer();
            try {
    Severity: Minor
    Found in src/Phan/Daemon.php - About 1 hr to fix

      Function runWithoutPcntl has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function runWithoutPcntl(CodeBase $code_base, Closure $file_path_lister): void
          {
              // This is a single threaded server, it only analyzes one TCP request at a time
              $socket_server = self::createDaemonStreamSocketServer();
              try {
      Severity: Minor
      Found in src/Phan/Daemon.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method run() has an NPath complexity of 268. The configured NPath complexity threshold is 200.
      Open

          public static function run(CodeBase $code_base, Closure $file_path_lister): ?Request
          {
              if (Config::getValue('language_server_use_pcntl_fallback')) {
                  self::runWithoutPcntl($code_base, $file_path_lister);
                  // Not reachable
      Severity: Minor
      Found in src/Phan/Daemon.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method run() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          public static function run(CodeBase $code_base, Closure $file_path_lister): ?Request
          {
              if (Config::getValue('language_server_use_pcntl_fallback')) {
                  self::runWithoutPcntl($code_base, $file_path_lister);
                  // Not reachable
      Severity: Minor
      Found in src/Phan/Daemon.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method createDaemonStreamSocketServer() contains an exit expression.
      Open

                  exit(1);
      Severity: Minor
      Found in src/Phan/Daemon.php by phpmd

      ExitExpression

      Since: 0.2

      An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

      Example

      class Foo {
          public function bar($param)  {
              if ($param === 42) {
                  exit(23);
              }
          }
      }

      Source https://phpmd.org/rules/design.html#exitexpression

      The method run() contains an exit expression.
      Open

                  exit(0);
      Severity: Minor
      Found in src/Phan/Daemon.php by phpmd

      ExitExpression

      Since: 0.2

      An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

      Example

      class Foo {
          public function bar($param)  {
              if ($param === 42) {
                  exit(23);
              }
          }
      }

      Source https://phpmd.org/rules/design.html#exitexpression

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      $previous_error_handler = \set_error_handler(
                          static function (int $severity, string $message, string $file, int $line) use (&$previous_error_handler): bool {
                              self::debugf("In new error handler '$message'");
                              if (!\preg_match('/stream_socket_accept/i', $message)) {
                                  return $previous_error_handler($severity, $message, $file, $line);
      Severity: Minor
      Found in src/Phan/Daemon.php and 1 other location - About 45 mins to fix
      src/Phan/Daemon.php on lines 82..88

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 96.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      $previous_error_handler = \set_error_handler(static function (int $severity, string $message, string $file, int $line) use (&$previous_error_handler): bool {
                          self::debugf("In new error handler '$message'");
                          if (!\preg_match('/stream_socket_accept/i', $message)) {
                              return $previous_error_handler($severity, $message, $file, $line);
                          }
      Severity: Minor
      Found in src/Phan/Daemon.php and 1 other location - About 45 mins to fix
      src/Phan/Daemon.php on lines 138..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 96.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status