Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Language/AnnotatedUnionType.php

Summary

Maintainability
B
5 hrs
Test Coverage

The class AnnotatedUnionType has an overall complexity of 54 which is very high. The configured complexity threshold is 50.
Open

class AnnotatedUnionType extends UnionType
{
    protected const DEFINITELY_UNDEFINED = 1;

    /**
Severity: Minor
Found in src/Phan/Language/AnnotatedUnionType.php by phpmd

AnnotatedUnionType has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class AnnotatedUnionType extends UnionType
{
    protected const DEFINITELY_UNDEFINED = 1;

    /**
Severity: Minor
Found in src/Phan/Language/AnnotatedUnionType.php - About 2 hrs to fix

    Function isEqualTo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function isEqualTo(UnionType $union_type): bool
    {
        if ($this === $union_type) {
            return true;
        }
    Severity: Minor
    Found in src/Phan/Language/AnnotatedUnionType.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return false;
    Severity: Major
    Found in src/Phan/Language/AnnotatedUnionType.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in src/Phan/Language/AnnotatedUnionType.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return true;
        Severity: Major
        Found in src/Phan/Language/AnnotatedUnionType.php - About 30 mins to fix

          Function isIdenticalTo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function isIdenticalTo(UnionType $union_type): bool
    {
        if ($this === $union_type) {
            return true;
        }
          Severity: Minor
          Found in src/Phan/Language/AnnotatedUnionType.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid variables with short names like $id. Configured minimum length is 3.
          Open

                  $id = parent::generateUniqueId();
          Severity: Minor
          Found in src/Phan/Language/AnnotatedUnionType.php by phpmd

          ShortVariable

          Since: 0.2

          Detects when a field, local, or parameter has a very short name.

          Example

          class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

          Source https://phpmd.org/rules/naming.html#shortvariable

          There are no issues that match your filters.

          Category
          Status