src/Phan/Language/Element/Func.php

Summary

Maintainability
C
1 day
Test Coverage

Method fromNode has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function fromNode(
        Context $context,
        CodeBase $code_base,
        Node $node,
        FullyQualifiedFunctionName $fqsen
Severity: Major
Found in src/Phan/Language/Element/Func.php - About 4 hrs to fix

    File Func.php has 324 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    declare(strict_types=1);
    
    namespace Phan\Language\Element;
    Severity: Minor
    Found in src/Phan/Language/Element/Func.php - About 3 hrs to fix

      The class Func has an overall complexity of 56 which is very high. The configured complexity threshold is 50.
      Open

      class Func extends AddressableElement implements FunctionInterface
      {
          use Analyzable;
          use Memoize;
          use FunctionTrait {
      Severity: Minor
      Found in src/Phan/Language/Element/Func.php by phpmd

      Function fromNode has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function fromNode(
              Context $context,
              CodeBase $code_base,
              Node $node,
              FullyQualifiedFunctionName $fqsen
      Severity: Minor
      Found in src/Phan/Language/Element/Func.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Context $context,
              string $name,
              UnionType $type,
              int $flags,
              FullyQualifiedFunctionName $fqsen,
      Severity: Minor
      Found in src/Phan/Language/Element/Func.php - About 45 mins to fix

        Function addReference has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function addReference(FileRef $file_ref): void
            {
                if (Config::get_track_references()) {
                    // Currently, we don't need to track references to PHP-internal methods/functions/constants
                    // such as PHP_VERSION, strlen(), Closure::bind(), etc.
        Severity: Minor
        Found in src/Phan/Language/Element/Func.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getClosureOverrideFQSEN has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private static function getClosureOverrideFQSEN(
                CodeBase $code_base,
                Context $context,
                Type $closure_scope_type,
                Node $node
        Severity: Minor
        Found in src/Phan/Language/Element/Func.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        The method fromNode() has 156 lines of code. Current threshold is set to 100. Avoid really long methods.
        Open

            public static function fromNode(
                Context $context,
                CodeBase $code_base,
                Node $node,
                FullyQualifiedFunctionName $fqsen
        Severity: Minor
        Found in src/Phan/Language/Element/Func.php by phpmd

        The method fromNode() has an NPath complexity of 1280. The configured NPath complexity threshold is 200.
        Open

            public static function fromNode(
                Context $context,
                CodeBase $code_base,
                Node $node,
                FullyQualifiedFunctionName $fqsen
        Severity: Minor
        Found in src/Phan/Language/Element/Func.php by phpmd

        NPathComplexity

        Since: 0.1

        The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

        Example

        class Foo {
            function bar() {
                // lots of complicated code
            }
        }

        Source https://phpmd.org/rules/codesize.html#npathcomplexity

        The method fromNode() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
        Open

            public static function fromNode(
                Context $context,
                CodeBase $code_base,
                Node $node,
                FullyQualifiedFunctionName $fqsen
        Severity: Minor
        Found in src/Phan/Language/Element/Func.php by phpmd

        CyclomaticComplexity

        Since: 0.1

        Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

        Example

        // Cyclomatic Complexity = 11
        class Foo {
        1   public function example() {
        2       if ($a == $b) {
        3           if ($a1 == $b1) {
                        fiddle();
        4           } elseif ($a2 == $b2) {
                        fiddle();
                    } else {
                        fiddle();
                    }
        5       } elseif ($c == $d) {
        6           while ($c == $d) {
                        fiddle();
                    }
        7        } elseif ($e == $f) {
        8           for ($n = 0; $n < $h; $n++) {
                        fiddle();
                    }
                } else {
                    switch ($z) {
        9               case 1:
                            fiddle();
                            break;
        10              case 2:
                            fiddle();
                            break;
        11              case 3:
                            fiddle();
                            break;
                        default:
                            fiddle();
                            break;
                    }
                }
            }
        }

        Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

        The class Func has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13.
        Open

        class Func extends AddressableElement implements FunctionInterface
        {
            use Analyzable;
            use Memoize;
            use FunctionTrait {
        Severity: Minor
        Found in src/Phan/Language/Element/Func.php by phpmd

        CouplingBetweenObjects

        Since: 1.1.0

        A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

        Example

        class Foo {
            /**
             * @var \foo\bar\X
             */
            private $x = null;
        
            /**
             * @var \foo\bar\Y
             */
            private $y = null;
        
            /**
             * @var \foo\bar\Z
             */
            private $z = null;
        
            public function setFoo(\Foo $foo) {}
            public function setBar(\Bar $bar) {}
            public function setBaz(\Baz $baz) {}
        
            /**
             * @return \SplObjectStorage
             * @throws \OutOfRangeException
             * @throws \InvalidArgumentException
             * @throws \ErrorException
             */
            public function process(\Iterator $it) {}
        
            // ...
        }

        Source https://phpmd.org/rules/design.html#couplingbetweenobjects

        There are no issues that match your filters.

        Category
        Status