Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Language/Element/Property.php

Summary

Maintainability
C
1 day
Test Coverage

Property has 34 functions (exceeds 20 allowed). Consider refactoring.
Open

class Property extends ClassElement
{
    use ElementFutureUnionType;
    use ClosedScopeElement;
Severity: Minor
Found in src/Phan/Language/Element/Property.php - About 4 hrs to fix

    The class Property has an overall complexity of 57 which is very high. The configured complexity threshold is 50.
    Open

    class Property extends ClassElement
{
    use ElementFutureUnionType;
    use ClosedScopeElement;
    Severity: Minor
    Found in src/Phan/Language/Element/Property.php by phpmd

    File Property.php has 298 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Phan\Language\Element;
    Severity: Minor
    Found in src/Phan/Language/Element/Property.php - About 3 hrs to fix

      Method getFutureUnionType has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getFutureUnionType(): ?UnionType
    {
        $future_union_type = $this->future_union_type;
        if ($future_union_type === null) {
            return null;
      Severity: Minor
      Found in src/Phan/Language/Element/Property.php - About 1 hr to fix

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Context $context,
        string $name,
        UnionType $type,
        int $flags,
        FullyQualifiedPropertyName $fqsen,
        Severity: Minor
        Found in src/Phan/Language/Element/Property.php - About 45 mins to fix

          Function inheritStaticUnionType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function inheritStaticUnionType(FullyQualifiedClassName $old, FullyQualifiedClassName $new): void
    {
        $union_type = $this->getUnionType();
        foreach ($union_type->getTypeSet() as $type) {
            if (!$type->isObjectWithKnownFQSEN()) {
          Severity: Minor
          Found in src/Phan/Language/Element/Property.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getFutureUnionType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getFutureUnionType(): ?UnionType
    {
        $future_union_type = $this->future_union_type;
        if ($future_union_type === null) {
            return null;
          Severity: Minor
          Found in src/Phan/Language/Element/Property.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The class Property has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
          Open

          class Property extends ClassElement
{
    use ElementFutureUnionType;
    use ClosedScopeElement;
          Severity: Minor
          Found in src/Phan/Language/Element/Property.php by phpmd

          CouplingBetweenObjects

          Since: 1.1.0

          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

          Example

          class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

          There are no issues that match your filters.

          Category
          Status