etsy/phan

TypedElement has 26 functions (exceeds 20 allowed). Consider refactoring.

Open

abstract class TypedElement implements TypedElementInterface
{
    /**
     * @var string
     * The name of the typed structural element

The 'getFlagsHasState()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getFlagsHasState(int $flag): bool
    {
        return ($this->flags & $flag) === $flag;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getPhanFlagsHasState()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getPhanFlagsHasState(int $flag): bool
    {
        return ($this->phan_flags & $flag) === $flag;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}