Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Language/Scope.php

Summary

Maintainability
B
6 hrs
Test Coverage

Scope has 36 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class Scope
{
    public const IN_FUNCTION_LIKE_SCOPE = 0x01;
    // If this is set, and neither IN_TRAIT_SCOPE and IN_INTERFACE_SCOPE are set, this is
    public const IN_CLASS_SCOPE         = 0x02;
Severity: Minor
Found in src/Phan/Language/Scope.php - About 4 hrs to fix

    The class Scope has an overall complexity of 52 which is very high. The configured complexity threshold is 50.
    Open

    abstract class Scope
{
    public const IN_FUNCTION_LIKE_SCOPE = 0x01;
    // If this is set, and neither IN_TRAIT_SCOPE and IN_INTERFACE_SCOPE are set, this is
    public const IN_CLASS_SCOPE         = 0x02;
    Severity: Minor
    Found in src/Phan/Language/Scope.php by phpmd

    Function identifyLowestCommonAncestor has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function identifyLowestCommonAncestor(array $scope_list): ?Scope
    {
        $counts = [];
        $N = count($scope_list);
        foreach ($scope_list as $i => $scope) {
    Severity: Minor
    Found in src/Phan/Language/Scope.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getDifferingVariables has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function getDifferingVariables(array $scope_list): array
    {
        if (count($scope_list) < 2) {
            return [];
        }
    Severity: Minor
    Found in src/Phan/Language/Scope.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid variables with short names like $N. Configured minimum length is 3.
    Open

            $N = count($scope_list);
    Severity: Minor
    Found in src/Phan/Language/Scope.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $id. Configured minimum length is 3.
    Open

                $id = spl_object_id($scope);
    Severity: Minor
    Found in src/Phan/Language/Scope.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    There are no issues that match your filters.

    Category
    Status