etsy/phan

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function __construct(UnionType $type, bool $is_variadic, bool $is_reference, bool $is_optional, string $name = null)

Avoid variables with short names like $i. Configured minimum length is 3.

Open

    public function asNonVariadicRegularParameter(int $i): Parameter

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Avoid variables with short names like $i. Configured minimum length is 3.

Open

    public function asRegularParameter(int $i): Parameter

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}