Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Language/Type/NativeType.php

Summary

Maintainability
C
1 day
Test Coverage

NativeType has 31 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class NativeType extends Type
{
    public const NAME = '';

    /** @phan-override */
Severity: Minor
Found in src/Phan/Language/Type/NativeType.php - About 3 hrs to fix

    The class NativeType has an overall complexity of 51 which is very high. The configured complexity threshold is 50.
    Open

    abstract class NativeType extends Type
{
    public const NAME = '';

    /** @phan-override */
    Severity: Minor
    Found in src/Phan/Language/Type/NativeType.php by phpmd

    Method initializeTypeCastingMatrix has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function initializeTypeCastingMatrix(): array
    {
        /**
         * @return array<string,bool>
         */
    Severity: Minor
    Found in src/Phan/Language/Type/NativeType.php - About 1 hr to fix

      The class NativeType has a coupling between objects value of 29. Consider to reduce the number of dependencies under 13.
      Open

      abstract class NativeType extends Type
{
    public const NAME = '';

    /** @phan-override */
      Severity: Minor
      Found in src/Phan/Language/Type/NativeType.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          protected function isSubtypeOfNonNullableType(Type $type): bool
    {
        // Anything is a subtype of mixed or ?mixed
        if ($type instanceof MixedType) {
            return true;
      Severity: Major
      Found in src/Phan/Language/Type/NativeType.php and 2 other locations - About 2 hrs to fix
      src/Phan/Language/Type/NativeType.php on lines 117..141
      src/Phan/Language/Type/NativeType.php on lines 148..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          protected function canCastToNonNullableType(Type $type): bool
    {
        // Anything can cast to mixed or ?mixed
        // Not much of a distinction in nullable mixed, except to emphasize in comments that it definitely can be null.
        // MixedType overrides the canCastTo*Type methods to always return true.
      Severity: Major
      Found in src/Phan/Language/Type/NativeType.php and 2 other locations - About 2 hrs to fix
      src/Phan/Language/Type/NativeType.php on lines 148..172
      src/Phan/Language/Type/NativeType.php on lines 174..196

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          protected function canCastToNonNullableTypeWithoutConfig(Type $type): bool
    {
        // Anything can cast to mixed or ?mixed
        // Not much of a distinction in nullable mixed, except to emphasize in comments that it definitely can be null.
        // MixedType overrides the canCastTo*Type methods to always return true.
      Severity: Major
      Found in src/Phan/Language/Type/NativeType.php and 2 other locations - About 2 hrs to fix
      src/Phan/Language/Type/NativeType.php on lines 117..141
      src/Phan/Language/Type/NativeType.php on lines 174..196

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 121.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status