Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Language/Type/NonEmptyStringType.php

Summary

Maintainability
A
2 hrs
Test Coverage

Function weaklyOverlaps has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function weaklyOverlaps(Type $other): bool
    {
        // TODO: Could be stricter
        if ($other instanceof ScalarType) {
            if ($other instanceof LiteralTypeInterface) {
Severity: Minor
Found in src/Phan/Language/Type/NonEmptyStringType.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        return parent::canCastToNonNullableType($type);
Severity: Major
Found in src/Phan/Language/Type/NonEmptyStringType.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return $type instanceof CallableType || $type instanceof MixedType || $type instanceof TemplateType;
    Severity: Major
    Found in src/Phan/Language/Type/NonEmptyStringType.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return parent::canCastToNonNullableType($type);
      Severity: Major
      Found in src/Phan/Language/Type/NonEmptyStringType.php - About 30 mins to fix

        Function isSubtypeOfNonNullableType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function isSubtypeOfNonNullableType(Type $type): bool
    {
        if ($type instanceof ScalarType) {
            if ($type instanceof StringType) {
                if ($type instanceof LiteralStringType) {
        Severity: Minor
        Found in src/Phan/Language/Type/NonEmptyStringType.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status