Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Language/Type/VoidType.php

Summary

Maintainability
C
1 day
Test Coverage

VoidType has 29 functions (exceeds 20 allowed). Consider refactoring.
Open

final class VoidType extends NativeType implements LiteralTypeInterface
{
    /** @phan-override */
    public const NAME = 'void';
Severity: Minor
Found in src/Phan/Language/Type/VoidType.php - About 3 hrs to fix

    The class VoidType has 11 public methods. Consider refactoring VoidType to keep number of public methods under 10.
    Open

    final class VoidType extends NativeType implements LiteralTypeInterface
{
    /** @phan-override */
    public const NAME = 'void';
    Severity: Minor
    Found in src/Phan/Language/Type/VoidType.php by phpmd

    TooManyPublicMethods

    Since: 0.1

    A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

    By default it ignores methods starting with 'get' or 'set'.

    Example

    Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

    Function canCastToTypeHandlingTemplates has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function canCastToTypeHandlingTemplates(Type $type, CodeBase $code_base): bool
    {
        // Check to see if we have an exact object match
        if ($this === $type) {
            return true;
    Severity: Minor
    Found in src/Phan/Language/Type/VoidType.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function canCastToType has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function canCastToType(Type $type): bool
    {
        // Check to see if we have an exact object match
        if ($this === $type) {
            return true;
    Severity: Minor
    Found in src/Phan/Language/Type/VoidType.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return parent::canCastToNonNullableTypeHandlingTemplates($type, $code_base);
    Severity: Major
    Found in src/Phan/Language/Type/VoidType.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return true;
      Severity: Major
      Found in src/Phan/Language/Type/VoidType.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $type->isNullable();
        Severity: Major
        Found in src/Phan/Language/Type/VoidType.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return false;
          Severity: Major
          Found in src/Phan/Language/Type/VoidType.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return true;
            Severity: Major
            Found in src/Phan/Language/Type/VoidType.php - About 30 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  public function canCastToType(Type $type): bool
    {
        // Check to see if we have an exact object match
        if ($this === $type) {
            return true;
              Severity: Major
              Found in src/Phan/Language/Type/VoidType.php and 1 other location - About 3 hrs to fix
              src/Phan/Language/Type/NullType.php on lines 88..118

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 155.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status