src/Phan/LanguageServer/GoToDefinitionRequest.php

Summary

Maintainability
D
1 day
Test Coverage

Function recordHoverTextForElementType has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    private function recordHoverTextForElementType(
        CodeBase $code_base,
        Context $context,
        TypedElementInterface $element
    ): void {
Severity: Minor
Found in src/Phan/LanguageServer/GoToDefinitionRequest.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File GoToDefinitionRequest.php has 306 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

declare(strict_types=1);

namespace Phan\LanguageServer;
Severity: Minor
Found in src/Phan/LanguageServer/GoToDefinitionRequest.php - About 3 hrs to fix

    The class GoToDefinitionRequest has an overall complexity of 65 which is very high. The configured complexity threshold is 50.
    Open

    final class GoToDefinitionRequest extends NodeInfoRequest
    {
        /** @var int self::REQUEST_* */
        private $request_type;
    
    

    Method recordHoverTextForElementType has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function recordHoverTextForElementType(
            CodeBase $code_base,
            Context $context,
            TypedElementInterface $element
        ): void {
    Severity: Minor
    Found in src/Phan/LanguageServer/GoToDefinitionRequest.php - About 1 hr to fix

      Function recordTypeOfElement has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          private function recordTypeOfElement(
              CodeBase $code_base,
              Context $context,
              TypedElementInterface $element
          ): void {
      Severity: Minor
      Found in src/Phan/LanguageServer/GoToDefinitionRequest.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function recordDefinitionOfTypeFQSEN has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private function recordDefinitionOfTypeFQSEN(
              CodeBase $code_base,
              FQSEN $type_fqsen
          ): void {
              $record_definition = function (AddressableElementInterface $element) use ($code_base): void {
      Severity: Minor
      Found in src/Phan/LanguageServer/GoToDefinitionRequest.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method recordDefinitionOfTypeFQSEN has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function recordDefinitionOfTypeFQSEN(
              CodeBase $code_base,
              FQSEN $type_fqsen
          ): void {
              $record_definition = function (AddressableElementInterface $element) use ($code_base): void {
      Severity: Minor
      Found in src/Phan/LanguageServer/GoToDefinitionRequest.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                return $variable_description;
        Severity: Major
        Found in src/Phan/LanguageServer/GoToDefinitionRequest.php - About 30 mins to fix

          The method recordHoverTextForElementType() has an NPath complexity of 1800. The configured NPath complexity threshold is 200.
          Open

              private function recordHoverTextForElementType(
                  CodeBase $code_base,
                  Context $context,
                  TypedElementInterface $element
              ): void {

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          The method recordHoverTextForElementType() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
          Open

              private function recordHoverTextForElementType(
                  CodeBase $code_base,
                  Context $context,
                  TypedElementInterface $element
              ): void {

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The class GoToDefinitionRequest has a coupling between objects value of 21. Consider to reduce the number of dependencies under 13.
          Open

          final class GoToDefinitionRequest extends NodeInfoRequest
          {
              /** @var int self::REQUEST_* */
              private $request_type;
          
          

          CouplingBetweenObjects

          Since: 1.1.0

          A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

          Example

          class Foo {
              /**
               * @var \foo\bar\X
               */
              private $x = null;
          
              /**
               * @var \foo\bar\Y
               */
              private $y = null;
          
              /**
               * @var \foo\bar\Z
               */
              private $z = null;
          
              public function setFoo(\Foo $foo) {}
              public function setBar(\Bar $bar) {}
              public function setBaz(\Baz $baz) {}
          
              /**
               * @return \SplObjectStorage
               * @throws \OutOfRangeException
               * @throws \InvalidArgumentException
               * @throws \ErrorException
               */
              public function process(\Iterator $it) {}
          
              // ...
          }

          Source https://phpmd.org/rules/design.html#couplingbetweenobjects

          There are no issues that match your filters.

          Category
          Status