Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Library/StringSuggester.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function findStringsBeginningWith has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    public function findStringsBeginningWith(string $name): array
    {
        $name = \strtolower($name);
        $name_len = strlen($name);
        $start = 0;
Severity: Minor
Found in src/Phan/Library/StringSuggester.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method findStringsBeginningWith has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function findStringsBeginningWith(string $name): array
    {
        $name = \strtolower($name);
        $name_len = strlen($name);
        $start = 0;
Severity: Minor
Found in src/Phan/Library/StringSuggester.php - About 1 hr to fix

    Function getSuggestions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getSuggestions(string $name): array
    {
        if (!$this->strings || $name === '') {
            return [];
        }
    Severity: Minor
    Found in src/Phan/Library/StringSuggester.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $result;
    Severity: Major
    Found in src/Phan/Library/StringSuggester.php - About 30 mins to fix

      Avoid variables with short names like $N. Configured minimum length is 3.
      Open

              $N = \count($arr);
      Severity: Minor
      Found in src/Phan/Library/StringSuggester.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

      Source https://phpmd.org/rules/naming.html#shortvariable

      There are no issues that match your filters.

      Category
      Status