Function getReturnTypeOverridesStatic has a Cognitive Complexity of 150 (exceeds 5 allowed). Consider refactoring.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        $mixed_type  = MixedType::instance(false);
        $false_type  = FalseType::instance(false);
        $array_type  = ArrayType::instance(false);

• Read up
  Read up

Method getReturnTypeOverridesStatic has 531 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        $mixed_type  = MixedType::instance(false);
        $false_type  = FalseType::instance(false);
        $array_type  = ArrayType::instance(false);

File ArrayReturnTypeOverridePlugin.php has 573 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

declare(strict_types=1);

namespace Phan\Plugin\Internal;

The class ArrayReturnTypeOverridePlugin has an overall complexity of 99 which is very high. The configured complexity threshold is 50.

Open

final class ArrayReturnTypeOverridePlugin extends PluginV3 implements
    ReturnTypeOverrideCapability
{

    /**

• Exclude checks
  • Disable engine
  • Disable check

Avoid deeply nested control flow statements.

Open

                                if (!Config::get_quick_mode()) {
                                    $analyzer = new PostOrderAnalysisVisitor($code_base, $context, []);
                                    $analyzer->analyzeCallableWithArgumentTypes([$passed_array_element_types], $filter_function);
                                }

Avoid too many return statements within this method.

Open

                return NullType::instance(false)->asRealUnionType();

Avoid too many return statements within this method.

Open

                        return $result;

Avoid too many return statements within this method.

Open

                return $element_types->asNonEmptyGenericArrayTypes(GenericArrayType::KEY_INT);

Avoid too many return statements within this method.

Open

            return $function_return_types;

Avoid too many return statements within this method.

Open

                return $null_type->asRealUnionType();

Avoid too many return statements within this method.

Open

                return $null_type->asRealUnionType();

Avoid too many return statements within this method.

Open

             return /** @param list<Node|int|float|string> $args */ static function (CodeBase $code_base, Context $context, Func $function, array $args) use ($probably_real_assoc_array, $can_reduce_size): UnionType {
                if (\count($args) >= 1) {
                    $element_types = UnionTypeVisitor::unionTypeFromNode($code_base, $context, $args[0])->genericArrayTypes();
                    if (!$element_types->isEmpty()) {
                        return $element_types->withFlattenedTopLevelArrayShapeTypeInstances()

Avoid too many return statements within this method.

Open

                        return $probably_real_array;

Avoid too many return statements within this method.

Open

            return $key_type->withRealTypeSet(\array_merge($real_key_type->getTypeSet(), [$null_type]));

Avoid too many return statements within this method.

Open

                        return $generic_passed_array_type->withFlattenedTopLevelArrayShapeTypeInstances()
                                                         ->withMappedElementTypes(static function (UnionType $union_type): UnionType {
                                                            return $union_type->nonFalseyClone();
                                                         })
                                                         ->withAssociativeArrays(true)

Avoid too many return statements within this method.

Open

                return $mixed_type->asPHPDocUnionType();

Avoid too many return statements within this method.

Open

            return $return->withRealTypeSet($nullable_array_type_set);

Avoid too many return statements within this method.

Open

                return $real_nullable_array;

Avoid too many return statements within this method.

Open

                return $key_type->withRealTypeSet($int_or_string_or_null->getRealTypeSet());

Avoid too many return statements within this method.

Open

                return $array_map_function->getUnionType();

Avoid too many return statements within this method.

Open

                return $int_or_string_or_null;

Avoid too many return statements within this method.

Open

                return UnionType::fromFullyQualifiedRealString('int|string|null');

Avoid too many return statements within this method.

Open

                return $argument_type;

Avoid too many return statements within this method.

Open

            return $int_or_string;

Avoid too many return statements within this method.

Open

                    return $cache[$i];

Avoid too many return statements within this method.

Open

                return $element_types->asNonEmptyGenericArrayTypes($key_type_enum);

Avoid too many return statements within this method.

Open

                return $result->nonFalseyClone();

Avoid too many return statements within this method.

Open

            return $probably_real_assoc_array;

Avoid too many return statements within this method.

Open

                        return $result;

Avoid too many return statements within this method.

Open

            return $probably_real_array;

Avoid too many return statements within this method.

Open

            return $array_type->asPHPDocUnionType();

Avoid too many return statements within this method.

Open

                return $real_nullable_array;

Avoid too many return statements within this method.

Open

                return $array_map_function->getUnionType();

Avoid too many return statements within this method.

Open

                return $probably_real_array;

Avoid too many return statements within this method.

Open

            return $int_or_string_or_false;

Avoid too many return statements within this method.

Open

                return $probably_real_array;

Avoid too many return statements within this method.

Open

                return UnionType::fromFullyQualifiedPHPDocAndRealString('list<mixed>', '?list<mixed>');

Avoid too many return statements within this method.

Open

            return $result;

Avoid too many return statements within this method.

Open

                    return $key_type->withType($false_type)->withRealTypeSet($int_or_string_or_false->getTypeSet());

Avoid too many return statements within this method.

Open

                    return $generic_passed_array_type->withFlattenedTopLevelArrayShapeTypeInstances()
                                                     ->withAssociativeArrays(true)
                                                     ->withPossiblyEmptyArrays();

Avoid too many return statements within this method.

Open

                return $argument_type;

Avoid too many return statements within this method.

Open

            return $key_union_type->asListTypes()->withRealTypeSet($nullable_list_type_set);

Avoid too many return statements within this method.

Open

                return $key_type->withRealTypeSet($int_or_string_or_null->getRealTypeSet());

Avoid too many return statements within this method.

Open

                return $key_type->withType($null_type)->withRealTypeSet($int_or_string_or_null->getRealTypeSet());

Avoid too many return statements within this method.

Open

                return UnionType::fromFullyQualifiedRealString('?array');

Avoid too many return statements within this method.

Open

                                return false;

Avoid too many return statements within this method.

Open

                        return $union_type->hasRealTypeSet();

Avoid too many return statements within this method.

Open

            return $result;

Avoid too many return statements within this method.

Open

            return $types;

Avoid too many return statements within this method.

Open

                return UnionType::fromFullyQualifiedPHPDocAndRealString('list<mixed>', '?list<mixed>');

Avoid too many return statements within this method.

Open

                return $mixed_type->asPHPDocUnionType();

Avoid too many return statements within this method.

Open

            return $result_types->withRealTypeSet($nullable_array_type_set);

Avoid too many return statements within this method.

Open

                    return $cache_outer[$i];

Avoid too many return statements within this method.

Open

                return new UnionType(
                    [$array_shape_type, $false_type],
                    true,
                    [
                        ArrayShapeType::fromFieldTypes([

Avoid too many return statements within this method.

Open

                return $value_type->asGenericArrayTypes($key_type_enum);

Avoid too many return statements within this method.

Open

                return $false_type->asPHPDocUnionType();

Avoid too many return statements within this method.

Open

            return $value_type->asListTypes();

Avoid too many return statements within this method.

Open

                return $false_type->asPHPDocUnionType();

Avoid too many return statements within this method.

Open

            return $false_type->asPHPDocUnionType();

Avoid too many return statements within this method.

Open

                    return UnionType::fromFullyQualifiedPHPDocAndRealString('array', 'array|false');

Avoid too many return statements within this method.

Open

        return [
            // Gets the element types of the first
            'array_pop'   => $get_element_type_of_first_arg_check_nonempty_null,
            'array_shift' => $get_element_type_of_first_arg_check_nonempty_null,
            'current'     => $get_element_type_of_first_arg,

Avoid too many return statements within this method.

Open

            return $result->withRealTypeSet($probably_real_assoc_array_falsey->getRealTypeSet());

Avoid too many return statements within this method.

Open

                    return UnionType::fromFullyQualifiedPHPDocAndRealString('list', 'array|false');

The method getReturnTypeOverridesStatic() has an NPath complexity of 9223372036854775807. The configured NPath complexity threshold is 200.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        $mixed_type  = MixedType::instance(false);
        $false_type  = FalseType::instance(false);
        $array_type  = ArrayType::instance(false);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    function bar() {
        // lots of complicated code
    }
}

The method getReturnTypeOverridesStatic() has 662 lines of code. Current threshold is set to 100. Avoid really long methods.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        $mixed_type  = MixedType::instance(false);
        $false_type  = FalseType::instance(false);
        $array_type  = ArrayType::instance(false);

• Exclude checks
  • Disable engine
  • Disable check

The method getReturnTypeOverridesStatic() has a Cyclomatic Complexity of 97. The configured cyclomatic complexity threshold is 10.

Open

    private static function getReturnTypeOverridesStatic(): array
    {
        $mixed_type  = MixedType::instance(false);
        $false_type  = FalseType::instance(false);
        $array_type  = ArrayType::instance(false);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

The class ArrayReturnTypeOverridePlugin has a coupling between objects value of 21. Consider to reduce the number of dependencies under 13.

Open

final class ArrayReturnTypeOverridePlugin extends PluginV3 implements
    ReturnTypeOverrideCapability
{

    /**

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Avoid variables with short names like $i. Configured minimum length is 3.

Open

            $get_argument_type = static function ($argument, int $i) use ($code_base, $context, &$cache_outer): UnionType {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}