Sign upLogin

etsy/phan

View on GitHub
Star
src/Phan/Plugin/Internal/BuiltinSuppressionPlugin.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function computeIssueSuppressionList has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    private static function computeIssueSuppressionList(
        string $file_contents
    ): array {
        if (!\preg_match(self::SUPPRESS_ISSUE_REGEX, $file_contents)) {
            // If the **file** doesn't contain the regex we're looking for,
Severity: Minor
Found in src/Phan/Plugin/Internal/BuiltinSuppressionPlugin.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method computeIssueSuppressionList has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function computeIssueSuppressionList(
        string $file_contents
    ): array {
        if (!\preg_match(self::SUPPRESS_ISSUE_REGEX, $file_contents)) {
            // If the **file** doesn't contain the regex we're looking for,
Severity: Minor
Found in src/Phan/Plugin/Internal/BuiltinSuppressionPlugin.php - About 1 hr to fix

    Function yieldSuppressionCommentsOld has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function yieldSuppressionCommentsOld(
        string $file_contents
    ): Generator {
        foreach (\token_get_all($file_contents) as $token) {
            if (!\is_array($token)) {
    Severity: Minor
    Found in src/Phan/Plugin/Internal/BuiltinSuppressionPlugin.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function yieldSuppressionCommentsPhpToken has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function yieldSuppressionCommentsPhpToken(
        string $file_contents
    ): Generator {
        // @phan-suppress-next-line PhanUndeclaredClassMethod missing in php 8 before 8.0.0RC4
        foreach (PhpToken::tokenize($file_contents) as $token) {
    Severity: Minor
    Found in src/Phan/Plugin/Internal/BuiltinSuppressionPlugin.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method shouldSuppressIssue has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            CodeBase $code_base,
        Context $context,
        string $issue_type,
        int $lineno,
        array $parameters,
    Severity: Minor
    Found in src/Phan/Plugin/Internal/BuiltinSuppressionPlugin.php - About 45 mins to fix

      The method computeIssueSuppressionList() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          private static function computeIssueSuppressionList(
        string $file_contents
    ): array {
        if (!\preg_match(self::SUPPRESS_ISSUE_REGEX, $file_contents)) {
            // If the **file** doesn't contain the regex we're looking for,
      Severity: Minor
      Found in src/Phan/Plugin/Internal/BuiltinSuppressionPlugin.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      There are no issues that match your filters.

      Category
      Status